Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/651
LGTM. Did not notice the newly added method was actually covering that code
path. Thanks @anmolnar for following up!
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm According to Clover report:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-clover/184/clover-report/org/apache/zookeeper/server/EphemeralType.html
The method i
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/651
one comment - it would be good for the updated test of EphemeralType.get to
cover the code path of throwing an IllegalArgumentException. This was what I
referred to in my original comment about reduc
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
Committed. Thanks for the reviews.
@hanm If you still do have any concerns, please let me know, I'll address
them in a separate patch.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2447/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm do you still -1 this?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2428/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2425/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2423/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2411/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2406/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm do you accept this patch with my recent changes?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2336/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2334/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm No problem. I'll write some new tests to validate the edge cases of
`EphemeralType.get()`.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
Thanks folks for the review.
Need approval from a committer. @hanm ?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2298/
---
25 matches
Mail list logo
