Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/665
@maoling, we can port this back to 3.4 in the same Jira, I'll send out a PR
separately for that.
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/665
@lvfangmin look at the branch3.4 is not consistency with master.Could we
create a separate jira to backport this refactor to branch3.4 to keep them
consistency?
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/665
Yes, it's similar to ZOOKEEPER-1669, which uses sessionMap to reduce the
cost of close session, most of the code are identical as well.
In 3.4, it has the removeCnxn method defined in
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/665
- Very useful improvement. `closeSession` can really face a perfermance
issue when thousands of clients.
- This issue is very similar to
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/665
the change looks clean and logical, ready to commit
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2456/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/665
retest this please
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/665
The failure seems not related to this code change, I'll trigger another
round of test, this should be ready to get in.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2416/
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/665
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2408/
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/665
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2401/
---
13 matches
Mail list logo
