Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/719
Committed to master branch. Thanks @mkedwards !
It hasn't applied cleanly to 3.5, so I'll commit #707 separately.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/719
@anmolnar yes, it is okay
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
I believe #707 has @eolivelli's LGTM now.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/719
I'm waiting for @eolivelli 's feedback on the other PR.
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
Does this look fit to merge? I'm not a committer, so I'll need help
getting it merged. (The version targeted to branch-3.5 is #707.)
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/719
@mkedwards flakies
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/719
retest this please
---
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
I don't understand the test failures. Are these unrelated problems in
master?
---