[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137459820 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137459795 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -409,13 +409,15 @@ public void truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137008765 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r137003935 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -409,13 +409,15 @@ public void truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136739423 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136739382 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -395,11 +395,12 @@ else if (qp.getType() == Leader.SNAP) {

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136737378 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136732115 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -395,11 +395,12 @@ else if (qp.getType() == Leader.SNAP) {

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136732072 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/356#discussion_r136731827 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws

[GitHub] zookeeper pull request #356: ZOOKEEPER-2572: Fix potential resource leak in ...

GitHub user bitgaoshu opened a pull request: https://github.com/apache/zookeeper/pull/356 ZOOKEEPER-2572: Fix potential resource leak in FileTxnLog.truncate You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitgaoshu/zookeeper