[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/420 ---

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153636108 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test; -impor

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153652218 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test; -impor

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153610044 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test; -im

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153592393 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -413,20 +240,10 @@ public void testRestore() throws Exception { */

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153592079 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -332,20 +173,10 @@ public void testPad() throws Exception { */

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153592781 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -449,50 +267,25 @@ public void testRestoreWithTransactionErrors() throws Excep

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153592257 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -370,20 +202,17 @@ public void testRestore() throws Exception { //

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153591342 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test; -impor

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153591967 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -136,21 +113,10 @@ public void testLoad() throws Exception { */

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153584084 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test; -impor

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-27 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153354864 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -69,25 +54,42 @@ private static final int TRANSACTION_OVERHEAD = 2;

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-27 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153354717 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -69,25 +54,42 @@ private static final int TRANSACTION_OVERHEAD = 2;

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-17 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/420 ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java This patch is the trunk version of https://github.com/apache/zookeeper/pull/409 You can merge this pull request into a Git repository by