[GitHub] zookeeper pull request #486: ZOOKEEPER-2999: CMake build should use target-l...

2018-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/486 ---

[GitHub] zookeeper pull request #486: ZOOKEEPER-2999: CMake build should use target-l...

2018-03-25 Thread andschwa
Github user andschwa commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/486#discussion_r176987184 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] zookeeper pull request #486: ZOOKEEPER-2999: CMake build should use target-l...

2018-03-09 Thread andschwa
GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/486 ZOOKEEPER-2999: CMake build should use target-level commands CMake is using `include_directories`, which has global side effects, instead of the more explicit `target_include_directories`, to