[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/529 ---

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user timothyjward commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196731884 --- Diff: src/java/test/org/apache/zookeeper/test/WatcherTest.java --- @@ -140,6 +142,55 @@ public void processResult(int rc, String path, Object

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196712402 --- Diff: src/java/test/org/apache/zookeeper/test/WatcherTest.java --- @@ -140,6 +142,55 @@ public void processResult(int rc, String path, Object ctx) {

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196256868 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1438,6 +1436,11 @@ public void disconnect() { }

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user timothyjward commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196119877 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1438,6 +1436,11 @@ public void disconnect() { }

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user timothyjward commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196102971 --- Diff: src/java/main/org/apache/zookeeper/Watcher.java --- @@ -84,7 +84,14 @@ * client connection (the session) is no longer

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user timothyjward commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196090467 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1260,10 +1260,8 @@ public void run() { cleanup();

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949397 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1438,6 +1436,11 @@ public void disconnect() { }

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949453 --- Diff: src/java/main/org/apache/zookeeper/Watcher.java --- @@ -84,7 +84,14 @@ * client connection (the session) is no longer valid.

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949390 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1260,10 +1260,8 @@ public void run() { cleanup();