[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/579 ---

[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-27 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205924496 --- Diff: src/c/tests/zkServer.sh --- @@ -77,7 +77,7 @@ fi if [ "x${base_dir}" == "x" ] then -zk_base="../../"

[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205666254 --- Diff: src/c/tests/zkServer.sh --- @@ -77,7 +77,7 @@ fi if [ "x${base_dir}" == "x" ] then -zk_base="../../" +zk_base="../../../"

[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205666234 --- Diff: src/c/tests/zkServer.sh --- @@ -77,7 +77,7 @@ fi if [ "x${base_dir}" == "x" ] then -zk_base="../../" +zk_base="../../../"

[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205666190 --- Diff: src/c/tests/TestClient.cc --- @@ -325,7 +326,17 @@ class Zookeeper_simpleSystem : public CPPUNIT_NS::TestFixture CPPUNIT_ASSERT(zk

[GitHub] zookeeper pull request #579: [ZOOKEEPER-3095] Connect string fix for non-exi...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/579#discussion_r205666180 --- Diff: src/c/src/zookeeper.c --- @@ -842,11 +842,16 @@ static int resolve_hosts(const zhandle_t *zh, const char *hosts_in, addrvec_t *a }