Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/582
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207874376
--- Diff: .gitignore ---
@@ -79,3 +79,4 @@ src/c/depcomp
src/c/install-sh
src/c/ltmain.sh
src/c/missing
+/nbproject/private/
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207874562
--- Diff: nbproject/project.xml ---
@@ -0,0 +1,124 @@
+
--- End diff --
Same here. You don't want to commit your IDE specific files.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207705040
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704611
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704605
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsContext.java ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611064
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611617
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsContext.java ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611316
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205936167
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903481
--- Diff: src/java/main/org/apache/zookeeper/metrics/Summary.java ---
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902926
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902898
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903511
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsProvider.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205047955
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205008065
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205004380
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/582
ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper - MetricsProvider API
definition
Define the API which must be implemented by a Metrics Provider.
a MetricsProvider is a pluggable
18 matches
Mail list logo