Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223567109
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public Connec
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223347154
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public Conn
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223346987
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public Conn
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223215411
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public Conn
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/587
---
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207730177
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207727691
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207613222
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207535136
--- Diff:
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java ---
@@ -39,27 +44,44 @@ public void testMultipleServersChrootPath(){
Github user tamaashu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207521296
--- Diff:
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java ---
@@ -39,27 +44,44 @@ public void testMultipleServersChrootPath(){
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207090394
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r206983579
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r206987004
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/587
ZOOKEEPER-3106: Zookeeper client supports IPv6 address and document the
"IPV6 feature"
The related UTs in the `ConnectStringParserTest` have all passed,I also
tested it in the real IPv6 ENV.
14 matches
Mail list logo