[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-18 Thread nkalmar
Github user nkalmar closed the pull request at: https://github.com/apache/zookeeper/pull/670 ---

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225422359 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -23,7 +23,7 @@ import

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225419531 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -23,7 +23,7 @@ import

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225420100 --- Diff: zookeeper-common/pom.xml --- @@ -0,0 +1,123 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225420204 --- Diff: zookeeper-client/zookeeper-client-java/pom.xml --- @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225402543 --- Diff: zookeeper-client/zookeeper-client-java/pom.xml --- @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225402885 --- Diff: zookeeper-server/pom.xml --- @@ -0,0 +1,67 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225402462 --- Diff: zookeeper-common/pom.xml --- @@ -0,0 +1,123 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-16 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/670#discussion_r225402727 --- Diff: zookeeper-jute/pom.xml --- @@ -0,0 +1,169 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...

2018-10-15 Thread nkalmar
GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/670 DO_NOT_MERGE - MAVEN MIGRATION - Separation of server and client This is to show that unlike I thought at the start of maven migration, separating java client and server code is too much of a