Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Michael Han
ing we shouldn't do this (not a -1 from my side), I just > > have > > > >> my concerns mentioned above. > > > >> > > > >> Is there any Apache project doing this? Just out of curiosity. > > > >> > > > >> Regards, > > &g

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Enrico Olivelli
;m not saying we shouldn't do this (not a -1 from my side), I just > have > > >> my concerns mentioned above. > > >> > > >> Is there any Apache project doing this? Just out of curiosity. > > >> > > >> Regards, > > >> Norb

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Brian Nixon
e any Apache project doing this? Just out of curiosity. > >> > >> Regards, > >> Norbert > >> > >> > >> On Wed, May 8, 2019 at 2:34 PM Justin Ling Mao < > maoling199210...@sina.com> > >> wrote: > >> > >>> +1,A ver

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Norbert Kalmar
viewers' name.For the incentive, if someone participate >> in the review of PR, no matter whether he/she is a committer, we all need >> include his/her name? >> >> - Original Message - >> From: Norbert Kalmar >> To: dev@zookeeper.apache.org &

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Norbert Kalmar
suggest about the >>> sign-off of the Reviewers' name.For the incentive, if someone participate >>> in the review of PR, no matter whether he/she is a committer, we all need >>> include his/her name? >>> >>> - Original Message - >>> F

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Norbert Kalmar
r the incentive, if someone participate in the > review of PR, no matter whether he/she is a committer, we all need include > his/her name? > > - Original Message - > From: Norbert Kalmar > To: dev@zookeeper.apache.org > Subject: [Suggestion] Use Co-authored-by in commit

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Justin Ling Mao
: dev@zookeeper.apache.org Subject: [Suggestion] Use Co-authored-by in commit messages Date: 2019-05-08 17:36 Hi Devs, I've got this idea from HBase. So: when there is a patch that is abandoned by its original author for any reason, and it can no longer be merged, someone comes by, and asks t

[Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Norbert Kalmar
Hi Devs, I've got this idea from HBase. So: when there is a patch that is abandoned by its original author for any reason, and it can no longer be merged, someone comes by, and asks to continue to work on it. Usually the reply is to use the change freely or no reply at all. Either way, what people