Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Thank you to all voters. With 4 binding +1 votes and 1 non-binding +1 vote this vote passes. I'll cut this release tonight. Thanks, Abe On Mon, Apr 23, 2018, at 08:24, Flavio Junqueira wrote: > +1, verified the following: > > - checksums and signature > - build passes > - rat tool output

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1, verified the following: - checksums and signature - build passes - rat tool output does not indicate any problem - LICENSE and NOTICE look both ok - local simple smoke tests work -Flavio > On 2 Apr 2018, at 02:01, Michael Han wrote: > > +1 > > - verified xsum/sig. > -

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

The voting timeline for releases is a minimum to ensure everyone has the opportunity to participate, it's not a max. The vote can run for as long as necessary. Patrick On Fri, Apr 20, 2018 at 7:50 AM, Ted Yu wrote: > The original email said: > > bq. vote by March 31st

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

The original email said: bq. vote by March 31st 2018, IMHO Apr 30th is not far ahead :-) If you think RC1 should receive more vote, please extend the voting deadline. On Wed, Apr 18, 2018 at 1:29 PM, Abraham Fine wrote: > I'm waiting for one more additional vote on the

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

I'm waiting for one more additional vote on the release. When that is done it will be available. On Wed, Apr 18, 2018, at 12:38, Ted Yu wrote: > I don't see 3.4.12 artifact under > https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper > > Abraham: > Can you clarify ? > > Thanks >

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

I don't see 3.4.12 artifact under https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper Abraham: Can you clarify ? Thanks On Mon, Apr 16, 2018 at 9:35 AM, Ted Yu wrote: > Hi, > If I understand correctly, zookeeper users can expect maven artifacts for > 3.4.12

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hi, If I understand correctly, zookeeper users can expect maven artifacts for 3.4.12 to be posted soon. Thanks

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Thanks for following up Alex. On Fri, Apr 13, 2018, at 14:48, Alexander Shraer wrote: > We discussed with Pat offline and agreed to go without this patch, > especially since we need to patch 3 branches: 3.4, 3.5 and master.> We'll > prepare 3.5 and master and then commit all 3 together in time

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

We discussed with Pat offline and agreed to go without this patch, especially since we need to patch 3 branches: 3.4, 3.5 and master. We'll prepare 3.5 and master and then commit all 3 together in time for the next release. So Abe, please go ahead with your release. Alex On Fri, Apr 13, 2018 at

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hey folks. I've been on vacation. My 0.02 - given the release candidate is well underway, has sufficient votes/time to finalize, this is not a regression in 3.4.12 and it's not yet committed I would think we finalize/push 3.4.12 then quickly followup with a 3.4.13 that addresses this. Alex could

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Given that the primary driver of this release is to fix an issue with the misuse of dataDir and dataLogDir I would rather see this release make it out the door with minimal additional changes to core functionality so people can more confidently upgrade. What do you think Pat? Abe On Fri,

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Now that we have the fix, why delay it to next release? On Fri, Apr 13, 2018 at 11:09 AM Abraham Fine wrote: > Let's wait until the next release to include this fix. > > On Mon, Apr 9, 2018, at 15:14, Alexander Shraer wrote: > > Hi, > > > > Please take a look on the new PR for

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Let's wait until the next release to include this fix. On Mon, Apr 9, 2018, at 15:14, Alexander Shraer wrote: > Hi, > > Please take a look on the new PR for ZK-2959: > https://github.com/apache/zookeeper/pull/500 > If there are no further comments, I can commit it. > > Thanks, > Alex > > On

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hi, The PR for ZK-2959 already has +1. Can the PR be merged ? Thanks

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hi, Please take a look on the new PR for ZK-2959: https://github.com/apache/zookeeper/pull/500 If there are no further comments, I can commit it. Thanks, Alex On Fri, Apr 6, 2018 at 11:33 AM, Alexander Shraer wrote: > Hi, > > The bug described in ZOOKEEPER-2959 >

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hi, The bug described in ZOOKEEPER-2959 is that getEpochToPropose an waitForEpochAck do not distinguish between followers and observers. This can cause a candidate leader's acceptedEpoch to be updated with only support from observers. Same

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Hi Alex, Can you give more details about the data loss scenario in Jira ZOOKEEPER-2959 ? As far as I know, the leader will ignore the observers' ACK in waitForNewLeaderAck, so it will not start serve traffic until it received the actual quorum

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Btw we actually observed the described issue (data loss), thankfully in a test environment. So I thought this is important to share with the community. Unfortunately I don’t have time to run a new ZK release for this, so I’m not going to -1 your candidate, but we are actively working on a fix (ie

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Got that. I still believe it's a completely valid issue which has to be addressed, but it's not a showstopper. I'm afraid we're not going to convince each other, so it's probably Abe's call if he want to create another release candidate for the fix. I reviewed the code on github and I think it

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Yes sort of, FLE is finished, then enough observer's messages reach the leader before participant's messages do. Whether its rare depends on the number of observers and participants. For example with very few participants and many observers your chance of hitting this are quite high. Alex On

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Maybe I'm missing something here, but this looks like a rare edge case to me. Participants must finish the leader election successfully and right after enough followers should fail to send epoch to the leader, so observers can take it over. Is that description accurate? Andor On Thu, Apr 5,

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

To clarify - in a deployment with observers this bug can potentially cause data loss. A server could be elected leader based just on the support of observers, even if this servers data is stale wrt other followers. It is certainly a blocker, just not sure if for 3.4.11 or 3.4.12. Alex On Thu,

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

I don't think it's a blocker. The jira and PR has been open since last December and 3.4.11 has released without it. Although this bug is also important to fix, I believe it's more important to release a fix for the regression we've found in 3.4.11 asap. Abe, any thoughts? Regards, Andor On

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Sorry for coming in at the last moment. I'm not sure when the next 3.4 release is scheduled, so just wanted to mention this bug, which I believe is a blocker for either this or next release: https://issues.apache.org/jira/browse/ZOOKEEPER-2959 Best, Alex On Thu, Apr 5, 2018 at 9:09 AM, Ted Yu

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

Can the vote be closed ? It seems we have enough +1's Thanks

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 - verified xsum/sig. - release notes looks good. - verified cluster with different sizes. - verified with few 4lw commands. - verified data / log dir swap was fixed. - all unit test passed. On Wed, Mar 28, 2018 at 11:55 AM, Patrick Hunt wrote: > +1. sig/xsum verified, RAT

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 Verified using jdk 1.8.0_111 and CentOS 7.3.1611 env - successfully compiled and ran the tests, all passed. - xsum/sig verified, OK. - set up 3 node cluster, verified through zk cmds and a couple of 4lws, looks fine. Rakesh On Thu, Mar 29, 2018 at 12:25 AM, Patrick Hunt

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1. sig/xsum verified, RAT ran OK. I tested a few operational scenarios which seemed fine. Ran the tests and they passed. LGTM. Patrick On Mon, Mar 26, 2018 at 10:05 PM, Abraham Fine wrote: > This is a bugfix release candidate for 3.4.12. It fixes 22 issues, > including

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 checked signatures unit tests passed on Linux

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 for candidate 1 - verified signatures - unit test passed on Mac and Ubuntu 16.04 (including c++) - verified 3 node cluster Andor On Tue, Mar 27, 2018 at 7:05 AM, Abraham Fine wrote: > This is a bugfix release candidate for 3.4.12. It fixes 22 issues, > including issues

[VOTE] Apache ZooKeeper release 3.4.12 candidate 1

This is a bugfix release candidate for 3.4.12. It fixes 22 issues, including issues that affect incorrect handling of the dataDir and the dataLogDir. This candidate fixes an issue in the release notes of candidate 0. The full release notes are available at: