Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-03-03 Thread Patrick Hunt
-1 - "spotbugs-annotations-3.1.9.jar" is still being distributed in the lib directory. (I highlighted this in my comments on RC3 as well) Regards, Patrick On Wed, Feb 27, 2019 at 8:48 AM Andor Molnar wrote: > This is a bugfix release candidate for 3.4.14. It fixes 8 issues, mostly > build /

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-02-28 Thread Norbert Kalmar
p.s.: I didn't run into the error mentioned by Enrico. On Thu, Feb 28, 2019 at 3:44 PM Norbert Kalmar wrote: > +1 (non-binding) > > Note: tarball still contains /lib/spotbugs-annotations-3.1.9.jar in the > new release. No license file for it either. But I think this is intentional > and fine,

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-02-28 Thread Norbert Kalmar
+1 (non-binding) Note: tarball still contains /lib/spotbugs-annotations-3.1.9.jar in the new release. No license file for it either. But I think this is intentional and fine, right? Otherwise: checked signatures and checksums built from source (oracle jdk8 and openjdk 11.0.2) run java tests

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-02-28 Thread Enrico Olivelli
+1 (non binding) run java tests run smoke tests checked signatures and checksums all with Java8 on Fedora I am getting this error during the compilation of the c-client error: '%d' directive writing between 1 and 5 bytes into a region of size between 0 and 127 [-Werror=format-overflow=] [exec]

[VOTE] Apache ZooKeeper release 3.4.14 candidate 4

2019-02-27 Thread Andor Molnar
This is a bugfix release candidate for 3.4.14. It fixes 8 issues, mostly build / unit tests issues, dependency updates flagged by OWASP, NPE and a name resolution problem. Among these it also supports experimental Maven build and Markdown based documentation generation. The full release notes