Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-10 Thread Norbert Kalmar
Hi Jordan, It is available again. Rc1 got downvoted, so I created rc2 which is now available in the staging repo. I'll also write the email about it but before I'll just run a few more tests. - Norbert On Sun, Feb 9, 2020 at 4:43 PM Jordan Zimmerman wrote: > 3.5.7 is not in the staging repo. I

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-09 Thread Jordan Zimmerman
3.5.7 is not in the staging repo. I'd like to test with Curator. https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/ -Jordan > On Feb 7, 2020, at 7:29 AM, Norbert Kalmar wr

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-09 Thread Norbert Kalmar
Done, thank you Patrick! - Norbert On Fri, Feb 7, 2020 at 11:29 PM Patrick Hunt wrote: > fwiw I would also be -1 due to the known CVE addressed in 3.6 but not here: > https://github.com/apache/zookeeper/pull/1246 > > Norbert as RM can you pull this in to branch-3.5 and the next RC? > > Patrick

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Patrick Hunt
fwiw I would also be -1 due to the known CVE addressed in 3.6 but not here: https://github.com/apache/zookeeper/pull/1246 Norbert as RM can you pull this in to branch-3.5 and the next RC? Patrick On Fri, Feb 7, 2020 at 10:14 AM Norbert Kalmar wrote: > Thanks Damien! > > -1 from me for this rc

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Norbert Kalmar
Thanks Damien! -1 from me for this rc1. I'll start working on rc2! Damien already fixed the mentioned issue, I'll review and test. I tested my modification for the missing files (ZOOKEEPER-3718), my main issue is to use apache-release profile just like in master, or fix up the assembly for source

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Damien Diederen
Hi Norbert, all, Norbert wrote: > p.s.: These are pretty easy fixes to include/exclude the files Eniroc > mentioned, so on second thought probably worth fixing and do an rc2. > I'll create a jira and start to work on it. We'll see if anything else > comes up or how the vote goes. I'm afraid som

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Norbert Kalmar
Sorry for the name typo - *Enrico On Fri, Feb 7, 2020 at 2:24 PM Norbert Kalmar wrote: > p.s.: These are pretty easy fixes to include/exclude the files Eniroc > mentioned, so on second thought probably worth fixing and do an rc2. > I'll create a jira and start to work on it. We'll see if anythin

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Norbert Kalmar
p.s.: These are pretty easy fixes to include/exclude the files Eniroc mentioned, so on second thought probably worth fixing and do an rc2. I'll create a jira and start to work on it. We'll see if anything else comes up or how the vote goes. - Norbert On Fri, Feb 7, 2020 at 2:20 PM Norbert Kalmar

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Norbert Kalmar
Hi Enrico, I checked the release, you are right. I mainly did the comparison with the 3.5.6 release as there were no changes on file/dependency level really. All of these points stand for that release as well. That's why I didn't notice or thought of it as release breaking flaw. In my opinion, we

Re: [VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Enrico Olivelli
Hi Norbert, thank you for working on this. I see differences between the contents of the source tarball and the git tag (using Meld, as suggested by Patrick some month ago), namely: - there is not checkstyleSuppressions.xml file, and mvn checkstyle:check fails (it is not bound to the default lifec

[VOTE] Apache ZooKeeper release 3.5.7 candidate 1

2020-02-07 Thread Norbert Kalmar
This is the second bugfix release candidate for 3.5.7. It fixes 21 issues, including third party CVE fixes, potential data loss and potential split brain if some rare conditions exists. (I have signed rc0 with the wrong key - sorry for that). Everything else is unchanged from rc0. The full releas