Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 1

2022-12-18 Thread Szalay-Bekő Máté
I think it is best to fix this issue before doing the release, especially as Chris already provided the fix. Thank you for working on it!! Also thanks Enrico for the quick review! I merged ZOOKEEPER-4654 to all branches and will include it also

Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 1

2022-12-17 Thread Szalay-Bekő Máté
Hello Chris, I tried to reproduce the test build problem locally on docker, but was not able to do so. I used ubuntu 22.04 (which uses gcc 11 by default), installing gcc-12 (version: 12.1.0) and openssl (version: 3.0.2 15 Mar 2022). My steps were: docker run --volume ~/git:/git -it --rm ubuntu:2

Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 1

2022-12-16 Thread Chris Nauroth
Unfortunately, I discovered one more problem: a similar compilation error in C client test code. I filed this issue and pull request: https://issues.apache.org/jira/browse/ZOOKEEPER-4654 https://github.com/apache/zookeeper/pull/1967 I must have been compiling only the product code and not the tes

Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 1

2022-12-16 Thread Szalay-Bekő Máté
+1 (binding) I did the following tests for the release candidate: - verified checksum and gpg signature of the artifacts - I built the source code (incl. the C-client, using -Pfull-build) on Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0 - all the unit tests passed (both Jav

[VOTE] Apache ZooKeeper release 3.6.4 candidate 1

2022-12-16 Thread Szalay-Bekő Máté
This is a bugfix release candidate for 3.6.4. It fixes 41 issues, including CVE fixes, log4j1 removal (using reload4j from now) and various other bug fixes (thread leaks, data corruption, snapshotting and SASL related fixes). Please note, that based on our Release Strategy ( https://zookeeper.apac