[ https://issues.apache.org/jira/browse/ZOOKEEPER-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213971#comment-16213971 ]
Edward Ribeiro edited comment on ZOOKEEPER-2921 at 10/21/17 3:34 PM: --------------------------------------------------------------------- Hi [~randgalt] and [~phunt] {quote} That said having such a warning when request latency exceeds some threshold would also be useful. {quote} Isn't that what ZOOKEEPER-2770 is all about? Or I misunderstood this issue? There's a corresponding stale patch already: https://github.com/apache/zookeeper/pull/307 Wdyt? Please, let me know. Cheers! was (Author: eribeiro): Hi [~randgalt] and [~phunt] :smile: {quote} That said having such a warning when request latency exceeds some threshold would also be useful. {quote} Isn't that what ZOOKEEPER-2770 is all about? Or I misunderstood this issue? There's a corresponding stale patch already: https://github.com/apache/zookeeper/pull/307 Wdyt? Please, let me know. Cheers! > fsyncWarningThresholdMS is applied on each getChannel().force() - also needed > on entire commit > ---------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2921 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2921 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.5.3 > Reporter: Jordan Zimmerman > Priority: Minor > > FileTxnLog.commit() has a warning when an individual sync takes longer than > {{fsyncWarningThresholdMS}}. However, it would also be useful to warn when > the entire commit operation takes longer than {{fsyncWarningThresholdMS}} as > this can cause client connection failures. Currently, commit() can take > longer than 2/3 of a session but still not log a warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)