[
https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364660#comment-15364660
]
Edward Ribeiro edited comment on ZOOKEEPER-451 at 7/6/16 5:18 PM:
------------------------------------------------------------------
Cool patch, [~botond.hejj], gonna take a closer look soon. :) Some preliminary
review notes:
I think "enableQuotaErrors" is not quite a good config setting name because it
can lead to confusion. Why not something like "enforceQuotaLimit"? Ironically,
you use this exact same name as field name down into the code. ;)
IMHO, ZooKeeperMain.java should print out the exceeded amount and quora limit
besides the path (making it easier to debug misconfigurations production).
FYI, there's a typo in zooKeeper.c: "qouta"
Last but not least, it is important to document this new parameter in the
appropriate docs xml file. Your patch should include this too. Look for the
documentation related to other ZK configs.
PS: you should indicate the parts changed in the JIRA, so besides the server,
there was the c and Java client, right?
Cheers!
was (Author: eribeiro):
Cool patch, [~botond.hejj], gonna take a closer look soon. :) Some preliminary
review notes:
I think "enableQuotaErrors" is not quite a good config setting name because it
can lead to confusion. Why not something like "enforceQuotaLimit"? Ironically,
you use this exact same name as field name down into the code. ;)
IMHO, ZooKeeperMain.java should print out the exceeded amount and quora limit
besides the path (making it easier to debug misconfigurations production).
FYI, there's a typo in zooKeeper.c: "qouta"
Last but not least, it is important to document this new parameter in the
appropriate docs xml file. Your patch should include this too. Look for the
documentation related to other ZK configs.
Cheers!
> ZK should enforce quota
> -----------------------
>
> Key: ZOOKEEPER-451
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.2.0
> Reporter: Raghu S
> Assignee: Botond Hejj
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-451.patch
>
>
> Email exchange with Mahadev:
> Mahadev Konar wrote:
> > Hi Raghu,
> > We do have plans to enforce quota in future. Enforcing requires some more
> > work then just reporting. Reporting is a good enough tool for operations to
> > manage a zookeeper cluster but we would certainly like to enforce it in the
> > near future.
> >
> > Thanks
> > mahadev
> >
> >
> > On 6/18/09 7:01 PM, "rag...@yahoo.com" <rag...@yahoo.com> wrote:
> >
> >> Is there a reason why node count/byte quota is not actually enforced but
> >> rather ZK just warns? Are there any plans to enforce the quota in a future
> >> release?
> >>
> >> Thanks
> >> Raghu
> >>
> >>
> >>
> >
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
