[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471028#comment-13471028 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-05 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490589#comment-13490589 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I'm sorry for not making pr

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491031#comment-13491031 ] Hadoop QA commented on ZOOKEEPER-1558: -- +1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-06 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491344#comment-13491344 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Great, this one has gone th

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-06 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491706#comment-13491706 ] Thawan Kooburat commented on ZOOKEEPER-1558: - This is minor but you can m

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-06 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491906#comment-13491906 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Thanks for reviewing, Thawa

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2012-11-06 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492079#comment-13492079 ] Thawan Kooburat commented on ZOOKEEPER-1558: I agree that the current patc

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-02-08 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574366#comment-13574366 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I think this patch should g

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-04-18 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635863#comment-13635863 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Is there anyone opposed to

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-08-22 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747684#comment-13747684 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I'd really like to either g

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-09-17 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770096#comment-13770096 ] Flavio Junqueira commented on ZOOKEEPER-1558: - [~thawan], Could you please

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-09-30 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782369#comment-13782369 ] Thawan Kooburat commented on ZOOKEEPER-1558: I think the patch need to be

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-03 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785581#comment-13785581 ] Flavio Junqueira commented on ZOOKEEPER-1558: - You may be thinking about a

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-09 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790929#comment-13790929 ] Flavio Junqueira commented on ZOOKEEPER-1558: - [~thawan], could you please

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-09 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791169#comment-13791169 ] Thawan Kooburat commented on ZOOKEEPER-1558: Again, my concern is that the

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-10 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791574#comment-13791574 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I was actually thinking abo

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-10 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791843#comment-13791843 ] Thawan Kooburat commented on ZOOKEEPER-1558: Yeah, I think that should wor

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-11 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793042#comment-13793042 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Ok, I'll produce a new patc

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794598#comment-13794598 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-16 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797305#comment-13797305 ] Thawan Kooburat commented on ZOOKEEPER-1558: Minor style change request: p

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799259#comment-13799259 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of test

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-18 Thread Thawan Kooburat (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799531#comment-13799531 ] Thawan Kooburat commented on ZOOKEEPER-1558: Thanks Flavio, the patch look

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

2013-10-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799846#comment-13799846 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of test