Re: 2.4.9 ZooKeeperServer uninitialized variable

2016-09-17 Thread Flavio Junqueira
Actually, it seems related but not quite the same issue, it refers to JMX registration, which is what ZK-2026 was about. I need to have a more careful look into ZK-2383. -Flavio > On 17 Sep 2016, at 02:59, Rakesh Radhakrishnan wrote: > > Thanks for the analysis and

Re: 2.4.9 ZooKeeperServer uninitialized variable

2016-09-16 Thread Rakesh Radhakrishnan
Thanks for the analysis and discussions. There is already jira raised to address this case, ZOOKEEPER-2383. Its in patch available state now and waiting for more reviews & +1 votes to push it upstream. Appreciate help in resolving this and include this in 3.4.10 version. Rakesh On Sat, Sep 17,

Re: 2.4.9 ZooKeeperServer uninitialized variable

2016-09-16 Thread Flavio Junqueira
I've been able to repro this. There is a race in NIOServerCnxnFactory.startup. We start the cnxn factory before we call startup on the zookeeper server. If we call createSession from the cnxn factory before we start the server, then we get the NPE. An easy way to repro is to add a sleep here:

2.4.9 ZooKeeperServer uninitialized variable

2016-09-15 Thread Colin Dupee
It appears sessionTracker was intended to have a value of null, but simply has no value assigned (@109). This results in a failure to compare to null in startup (@415), and an object never being created. While the server seems to be at least partially functional, it does produce an NPE on