Re: Bug in Zookeeper 3.4.11 release

2018-01-18 Thread Andor Molnar
I created the jira and started to work on it. https://issues.apache.org/jira/browse/ZOOKEEPER-2967 Andor On Thu, Jan 18, 2018 at 6:15 AM, Andor Molnar wrote: > Perhaps we should introduce a check of some kind? If datalogdir is > different that datadir and snapshots exist in datalogdir we thr

Re: Bug in Zookeeper 3.4.11 release

2018-01-17 Thread Andor Molnar
Perhaps we should introduce a check of some kind? If datalogdir is different that datadir and snapshots exist in datalogdir we throw an exception and quit. What do you think? That definitely makes sense. Andor On Thu, Jan 18, 2018 at 12:58 AM, Patrick Hunt wrote: > Abe mentioned the following

Re: Bug in Zookeeper 3.4.11 release

2018-01-17 Thread Patrick Hunt
Abe mentioned the following on the jira "Perhaps we should introduce a check of some kind?" I agree with Abe on this - if you're new to ZK in 3.4.11 and you split the directories this commit is going to result in unexpected, and likely very bad, situation. Abe - is there a jira to add this check?

Re: Bug in Zookeeper 3.4.11 release

2018-01-08 Thread Andor Molnar
Thanks Camille. I closed the pull request. Andor On Mon, Jan 8, 2018 at 2:32 AM, Camille Fournier wrote: > Yeah, this is bad. I reviewed and merged the PR to get this process > started. > > On Fri, Jan 5, 2018 at 5:25 PM, Abraham Fine wrote: > > > I left a comment on the JIRA and I'm not sure

Re: Bug in Zookeeper 3.4.11 release

2018-01-07 Thread Camille Fournier
Yeah, this is bad. I reviewed and merged the PR to get this process started. On Fri, Jan 5, 2018 at 5:25 PM, Abraham Fine wrote: > I left a comment on the JIRA and I'm not sure what the conventional way to > proceed would be either. > > I think we should work to get a release out as quickly as p

Re: Bug in Zookeeper 3.4.11 release

2018-01-05 Thread Abraham Fine
I left a comment on the JIRA and I'm not sure what the conventional way to proceed would be either. I think we should work to get a release out as quickly as possible with this fix. In addition, I think we may want to add a check on startup that forces a failure if snapshots/logs are where they

Bug in Zookeeper 3.4.11 release

2018-01-03 Thread Andor Molnar
Hi all, Looks like we've a pretty serious bug in 3.4.11: https://issues.apache.org/jira/browse/ZOOKEEPER-2960 In a nutshell: ZK uses dataDir and dataLogDir parameters in the wrong order, meaning it tries to access logs in the snapshot folder and vica versa. Not sure what's the process in such ca