I have disabled the Maven precommit for branch-3.4 and I have also disable
ANT precommit for master.
We are keeping ANT only for
https://builds.apache.org/job/Zookeeper-trunk-single-thread/
this is the job that add the "SUCCESS|FAILURE integrated in master " on
JIRA tickets.
I have started a s
Il mer 12 giu 2019, 11:36 Norbert Kalmar ha
scritto:
> Thank Enrico, awesome work!
>
> I wanted to suggest to drop maven build on branch 3.4. We never really
> wanted to release or even migrate maven to 3.4, but for easier backports,
> we did.
> Even though maven is there, we said we will just ke
Thank Enrico, awesome work!
I wanted to suggest to drop maven build on branch 3.4. We never really
wanted to release or even migrate maven to 3.4, but for easier backports,
we did.
Even though maven is there, we said we will just keep releasing 3.4 with
ant for backward compatibility reasons. Plus
Patrick
I took a look to Yetus,
https://yetus.apache.org/documentation/0.10.0/precommit-basic/
and it is very cool.
I will make experiments but it will take time.
I am going to double check my list of stuff to migrate and if I am done I
will disable the ant based precommit only for master branch.
Il giorno lun 3 giu 2019 alle ore 10:48 Norbert Kalmar
ha scritto:
> Hi Enrico,
>
> Thanks for looking into this.
> I also agree on the points to be dropped. Patrick has a valid point on the
> contrib tests though. (Maybe a vote on dropping some contrib projects
> first? :) )
>
>
> I'd also lik
Hi Enrico,
Thanks for looking into this.
I also agree on the points to be dropped. Patrick has a valid point on the
contrib tests though. (Maybe a vote on dropping some contrib projects
first? :) )
I'd also like to add I get a lot of javadoc warnings on maven, I'm not sure
why Ant doesn't complai
Sounds reasonable. Have you looked at what Yetus provides? iiuc a number of
the hadoop ecosystem projects use it to provide base/consistent experience
wrt the build. Now that we're on Maven perhaps we should re-evaluate?
re #8 - I don't think we should compromise given contrib is still not
decided
Hi,
you can find here (1) the current ANT-based precommit script that runs
againsts every Github Pull Request .
These are the steps of the script and how we are doing the same in Maven:
1) check for @author tags -> handled with maven-checkstyle-plugin
2) Check for new tests in the patch -> not han
