Merge pull request using zk-merge-pr.py script

2016-12-15 Thread Rakesh Radhakrishnan
Hi, I have an observation about the merge PR python script. https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes I could see the commit made using this automated merge script is missing to edit the 'CHANGES.TXT' file and then add the jira details that correspond to the patch.

Re: Merge pull request using zk-merge-pr.py script

2016-12-15 Thread Michael Han
Good catch, I think a couple of recent commits on master branch missing editing of CHANGE.TXT How is CHANGE.TXT edited before migrating to git during a commit? Is it done automatically or manually (that a committer has to update the file)? On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan wr

Re: Merge pull request using zk-merge-pr.py script

2016-12-15 Thread Rakesh Radhakrishnan
Before migrating to git, committer has to update the CHANGE.TXT file manually and then push this along with the approved patch as a single commit. Thanks, Rakesh On 16-Dec-2016 11:16 AM, "Michael Han" wrote: Good catch, I think a couple of recent commits on master branch missing editing of CHAN

Re: Merge pull request using zk-merge-pr.py script

2016-12-15 Thread Michael Han
Maybe it's a good time to automate change log generation. Example: https://issues.apache.org/jira/browse/HADOOP-11731 On Thu, Dec 15, 2016 at 10:04 PM, Rakesh Radhakrishnan < rakeshr.apa...@gmail.com> wrote: > Before migrating to git, committer has to update the CHANGE.TXT file > manually and the