Re: Pull requests validation - Maven is active - heads up!

2019-02-06 Thread Norbert Kalmar
For me, option 2 sounds good, and I think it's better to go for smaller jobs from the beginning. It will be also helpful in identifying the problems on the PRs seeing the different tasks fail/pass. Thanks for taking this up Enrico! Best regards, Norbert On Wed, Feb 6, 2019 at 4:35 PM Enrico Oliv

Re: Pull requests validation - Maven is active - heads up!

2019-02-06 Thread Enrico Olivelli
With Andor and Norbert we are thinking to not run 'contrib' tests against Pull Requests. I have two proposals: Two "big" jobs vs "many small jobs" 1) Two big jobs: - One ANT build (the current one) - One Maven Build (build and test java core, c-client and run spotbugs) 2) Many small jobs: - On

Re: Pull requests validation - Maven is active - heads up!

2019-02-05 Thread Enrico Olivelli
Il giorno mar 5 feb 2019, 15:47 Norbert Kalmar ha scritto: > Great, thanks! > > One question: 3.4 builds are failing. It's because we run the tests on 1 > thread. I modified the main pom.xml's fork count to 1, but it looks like it > is still running parallel. Do you override forkcount on the job?

Re: Pull requests validation - Maven is active - heads up!

2019-02-05 Thread Norbert Kalmar
Great, thanks! One question: 3.4 builds are failing. It's because we run the tests on 1 thread. I modified the main pom.xml's fork count to 1, but it looks like it is still running parallel. Do you override forkcount on the job? (I can't see Jenkins config). It should be changed to 1, as PortAssig

Re: Pull requests validation - Maven is active - heads up!

2019-02-04 Thread Enrico Olivelli
Full build is now active on Maven Pull Request Builder Cheers Enrico Il giorno lun 4 feb 2019 alle ore 13:16 Enrico Olivelli ha scritto: > > @Andor > trying now with nightly build > https://builds.apache.org/job/zookeeper-master-maven/59/ > > If tests are running well, I will add -Pfull-build to

Re: Pull requests validation - Maven is active - heads up!

2019-02-04 Thread Enrico Olivelli
@Andor trying now with nightly build https://builds.apache.org/job/zookeeper-master-maven/59/ If tests are running well, I will add -Pfull-build to Pull Request Builder jobs Thank you for pointing out Stay tuned Enrico Il giorno dom 3 feb 2019 alle ore 22:10 Andor Molnár ha scritto: > > Great

Re: Pull requests validation - Maven is active - heads up!

2019-02-03 Thread Andor Molnár
Great work, thanks Enrico! Are u planning to enable C++ tests too? Andor On 2/2/19 10:32, Enrico Olivelli wrote: > Hi ZooKeepers, > I have enabled validation of Pull Requests with Maven. > > In order to trigger the tests with ANT add a comment with: > retest ant build > > In order to trigger t

Re: Pull requests validation - Maven is active - heads up!

2019-02-02 Thread Patrick Hunt
Looks good. Thanks Enrico! Patrick On Sat, Feb 2, 2019 at 1:32 AM Enrico Olivelli wrote: > Hi ZooKeepers, > I have enabled validation of Pull Requests with Maven. > > In order to trigger the tests with ANT add a comment with: > retest ant build > > In order to trigger the tests with MAVEN add

Pull requests validation - Maven is active - heads up!

2019-02-02 Thread Enrico Olivelli
Hi ZooKeepers, I have enabled validation of Pull Requests with Maven. In order to trigger the tests with ANT add a comment with: retest ant build In order to trigger the tests with MAVEN add a comment with: retest maven build see this configuration for reference https://builds.apache.org/job/