Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Il giorno ven 16 ott 2020 alle ore 16:07 Christopher ha scritto: > Since rat runs fairly quickly, and because it enforces license header > requirements that are mandated by ASF policy I find it very useful. > > However, I just ran into > https://issues.apache.org/jira/browse/ZOOKEEPER-3974, so ra

Re: Question about checkstyle execution

2020-10-16 Thread Christopher
Since rat runs fairly quickly, and because it enforces license header requirements that are mandated by ASF policy I find it very useful. However, I just ran into https://issues.apache.org/jira/browse/ZOOKEEPER-3974, so rat check only works on a clean checkout... and only before the generate-sourc

Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Spotbugs is too heavy so I prefer to have it disabled by default. Rat is not very useful so it is a no for me Enrico Il Ven 16 Ott 2020, 15:35 Christopher ha scritto: > What about apache-rat and spotbugs? Should those execute by default also? > > On Fri, Oct 16, 2020 at 9:29 AM Enrico Olivelli

Re: Question about checkstyle execution

2020-10-16 Thread Christopher
What about apache-rat and spotbugs? Should those execute by default also? On Fri, Oct 16, 2020 at 9:29 AM Enrico Olivelli wrote: > > Christopher, > I think it is only a leftover of the adoption of checkstyle. > > Feel free to send a patch and activate it by default > > > Enrico > > Il Ven 16 Ott

Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Christopher, I think it is only a leftover of the adoption of checkstyle. Feel free to send a patch and activate it by default Enrico Il Ven 16 Ott 2020, 15:25 Christopher ha scritto: > Hi ZK Devs, > > I am working on ZOOKEEPER-3973 and I noticed the existing Travis CI > job executes `checkst

Question about checkstyle execution

2020-10-16 Thread Christopher
Hi ZK Devs, I am working on ZOOKEEPER-3973 and I noticed the existing Travis CI job executes `checkstyle:check` on the command line. I checked the pom.xml files and there is an execution defined in the `` section of the main pom.xml and another one in the zookeeper-contrib/pom.xml. However, neithe