Re: Re: ZooKeeper 3.5 blocker issues

; > > > I will start a new email thread about this > > > > > > > > > > > > > > > Thank you Norbert! > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > Hopefully we will see maven running o

Re: Re: ZooKeeper 3.5 blocker issues

bert > > > > > > > > > > On Fri, Dec 21, 2018 at 7:20 AM Enrico Olivelli < > eolive...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > Il ven 21 dic 2018, 04:24 毛蛤丝 ha > > > scri

Re: Re: ZooKeeper 3.5 blocker issues

t; > > > > > > On Fri, Dec 21, 2018 at 7:20 AM Enrico Olivelli > > > > > wrote: > > > > > > > > > Il ven 21 dic 2018, 04:24 毛蛤丝 ha > > scritto: > > > > > > > > > > > @Norbert @Enrico > >

Re: Re: ZooKeeper 3.5 blocker issues

; > > so the CI with checkstyle should ingore the existing codes, only > act > > > upon > > > > > the new codes(new PR) > > > > > After that, we can clean up the violations in the code base one > > module > > > by > > > > >

Re: Re: ZooKeeper 3.5 blocker issues

odes, only act > > upon > > > > the new codes(new PR) > > > > After that, we can clean up the violations in the code base one > module > > by > > > > another,one package by another > > > > if we have the time(but i think we don't[sm

Re: Re: ZooKeeper 3.5 blocker issues

but i think we don't[smirk]) > > > > > > > Yes it is a task for 3.6.0. Not worth 3.5. > > We can engage new contributors for this task. It is easy and it does not > > require knowledge of ZK internals > > > > Enrico > > > > > >

Re: Re: ZooKeeper 3.5 blocker issues

es not > require knowledge of ZK internals > > Enrico > > > ----- 原始邮件 - > > 发件人：Enrico Olivelli > > 收件人：DevZooKeeper > > 主题：Re: ZooKeeper 3.5 blocker issues > > 日期：2018年12月20日 17点10分 > > > > > > Great > > Il giorno gio 20 d

Re: Re: ZooKeeper 3.5 blocker issues

ernals Enrico - 原始邮件 - > 发件人：Enrico Olivelli > 收件人：DevZooKeeper > 主题：Re: ZooKeeper 3.5 blocker issues > 日期：2018年12月20日 17点10分 > > > Great > Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar > ha scritto: > > > > Subtasks: > > Findbugs,

回复：Re: ZooKeeper 3.5 blocker issues

package by another if we have the time(but i think we don't[smirk]) - 原始邮件 - 发件人：Enrico Olivelli 收件人：DevZooKeeper 主题：Re: ZooKeeper 3.5 blocker issues 日期：2018年12月20日 17点10分 Great Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar ha scritto: > > Subtasks: > Findbugs, c

Re: Re: ZooKeeper 3.5 blocker issues

M 毛蛤丝 wrote: > > > > > @Norbert > > > this issue about Checkstyle is on your plan? > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3107 > > > - 原始邮件 - > > > 发件人：Norbert Kalmar > > > 收件人：dev@zookeeper.apache.org > > >

Re: Re: ZooKeeper 3.5 blocker issues

> @Norbert > > this issue about Checkstyle is on your plan? > > https://issues.apache.org/jira/browse/ZOOKEEPER-3107 > > ----- 原始邮件 - > > 发件人：Norbert Kalmar > > 收件人：dev@zookeeper.apache.org > > 主题：Re: ZooKeeper 3.5 blocker issues > > 日期：2018年12月20日

Re: Re: ZooKeeper 3.5 blocker issues

to this jira! Regards, Norbert On Thu, Dec 20, 2018 at 10:32 AM 毛蛤丝 wrote: > @Norbert > this issue about Checkstyle is on your plan? > https://issues.apache.org/jira/browse/ZOOKEEPER-3107 > - 原始邮件 - > 发件人：Norbert Kalmar > 收件人：dev@zookeeper.apache.org > 主题：Re: ZooKeeper 3

回复：Re: ZooKeeper 3.5 blocker issues

@Norbert this issue about Checkstyle is on your plan? https://issues.apache.org/jira/browse/ZOOKEEPER-3107 - 原始邮件 - 发件人：Norbert Kalmar 收件人：dev@zookeeper.apache.org 主题：Re: ZooKeeper 3.5 blocker issues 日期：2018年12月20日 17点07分 Subtasks: Findbugs, checkstyle - https://issues.apache.org/jira

Re: ZooKeeper 3.5 blocker issues

Il giorno gio 20 dic 2018 alle ore 10:20 Norbert Kalmar ha scritto: > > One more thing - for the CI integration, actually, Java reports from Clover > - by maven - should be already available on master. Basically we only > analyse zookeeper-server, but as it is planned to be seperated, I wrote >

Re: ZooKeeper 3.5 blocker issues

One more thing - for the CI integration, actually, Java reports from Clover - by maven - should be already available on master. Basically we only analyse zookeeper-server, but as it is planned to be seperated, I wrote Clover so it starts from root pom and aggregates the results. On Thu, Dec 20,

Re: ZooKeeper 3.5 blocker issues

Sure, sorry about that, I didn't check thoroughly the static analyser part. Spotbugs works for me! Thanks Enrico! On Thu, Dec 20, 2018 at 10:10 AM Enrico Olivelli wrote: > Great > > Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar > ha scritto: > > > > Subtasks: > > Findbugs,

Re: ZooKeeper 3.5 blocker issues

Great Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar ha scritto: > > Subtasks: > Findbugs, checkstyle - https://issues.apache.org/jira/browse/ZOOKEEPER-3223 We don't have checksyle. In my experience introducing checkstyle break every pending patch. I would like to narrow down this

Re: ZooKeeper 3.5 blocker issues

Subtasks: Findbugs, checkstyle - https://issues.apache.org/jira/browse/ZOOKEEPER-3223 CI integration - https://issues.apache.org/jira/browse/ZOOKEEPER-3224 Code coverage - https://issues.apache.org/jira/browse/ZOOKEEPER-3225 - I laready started this one and some of it is committed with the patch,

Re: ZooKeeper 3.5 blocker issues

Great. Can you create JIRA tickets for remaining subtask? So that I can pick them up? I volounter for spotbugs and for CI integration, but let's see the list Enrico Il gio 20 dic 2018, 07:21 Andor Molnar ha scritto: > Ok. Looks like ant still works properly, so let’s commit this patch and > you

Re: ZooKeeper 3.5 blocker issues

Ok. Looks like ant still works properly, so let’s commit this patch and you guys can collaborate to polish the Maven build. For now, it’s master-only. Thanks, Andor > On 2018. Dec 19., at 16:44, Norbert Kalmar > wrote: > > Thank you Enrico, I agree, that we could commit this patch at it's

Re: ZooKeeper 3.5 blocker issues

Thank you Enrico, I agree, that we could commit this patch at it's current state, it fulfills the original jira anyways. I'll see what's wrong with the java tests, but honestly, it looks like they're just flaky... runs well on local builds with 8 thread. Regards, Norbert On Wed, Dec 19, 2018 at

Re: ZooKeeper 3.5 blocker issues

Hi All, For assembly task I would promote the way how HBase works. They create a pure source and a bin tarball separately. Please see how they create a release here: https://github.com/apache/hbase/blob/master/dev-support/make_rc.sh We could probably use the well known "copy+paste technology" to

Re: ZooKeeper 3.5 blocker issues

Great work Norbert I you want I can help,especially for rat, findbugs (need to switch to spotbugs anyway) and OWASP stuff (recently I started using Maven Plugin in other projects) But I am not sure how can I help you concretely if we do not commit your work. We could commit the work as it is now,

Re: ZooKeeper 3.5 blocker issues

Hi everyone, Some update on the maven migration: I had a few bumps here and there (just looking at the latest patch Andor linked - https://github.com/apache/zookeeper/pull/708 - you can see on the commits). Current state is that the build works, tests run, but reports like findbugs, clover etc.

Re: ZooKeeper 3.5 blocker issues

Sure, good point. Let's put it on the list. Andor On Tue, Dec 18, 2018 at 12:17 AM Patrick Hunt wrote: > Are folks OK to wait on that OWASP issue I documented over the weekend? > afaict we are not affected but it would be good to get another pair of eyes > on it. > > Patrick > > On Mon, Dec

Re: ZooKeeper 3.5 blocker issues

Are folks OK to wait on that OWASP issue I documented over the weekend? afaict we are not affected but it would be good to get another pair of eyes on it. Patrick On Mon, Dec 17, 2018 at 2:55 PM Andor Molnár wrote: > Hi team, > > > I'm proudly announce that thanks to the joint effort from the

Re: ZooKeeper 3.5 blocker issues

Hi team, I'm proudly announce that thanks to the joint effort from the community, the 3.5 blockers list has become empty: "project = ZooKeeper AND resolution = Unresolved AND fixVersion = 3.5.5 AND priority in (blocker, critical) ORDER BY priority DESC, key ASC" Well... almost. All the

Re: ZooKeeper 3.5 blocker issues

Andor, Here is the PR to port ZK-3104 from master to 3.4: https://github.com/apache/zookeeper/pull/685. Fangmin On Fri, Nov 2, 2018 at 11:46 AM Fangmin Lv wrote: > Hi Andor, > > Is anyone working on ZK-2778? I can pick it up if there is no one working > on it yet. > > I'll open a 3.5 PR for

Re: ZooKeeper 3.5 blocker issues

Hi Andor, Is anyone working on ZK-2778? I can pick it up if there is no one working on it yet. I'll open a 3.5 PR for ZK-3104 today. Fangmin On Fri, Oct 26, 2018 at 3:33 AM Andor Molnar wrote: > Hi folks, > > You’ve probably realised lots of update emails coming from Jira. Please be > aware

Re: ZooKeeper 3.5 blocker issues

Hi folks, You’ve probably realised lots of update emails coming from Jira. Please be aware that we’ve updated a bunch of open blocker/critical 3.5 tickets to reflect to what we discussed in this email. If you open up the following jira filter: project = ZooKeeper and resolution = Unresolved

Re: ZooKeeper 3.5 blocker issues

Hi, Let me summarize and give a quick update on the outstanding issues for 3.5 GA: - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external connection requests.) - ZOOKEEPER-3021 Migrate project

Re: ZooKeeper 3.5 blocker issues

Hi All, I would add ZOOKEEPER-3021 Migrate project structure to Maven build as a blocker too. Since the migration has started it would be good to finish before releasing ZK 3.5.x GA. ZOOKEEPER-925

Re: ZooKeeper 3.5 blocker issues

Oh, sorry for the confusion, I should provide more context. Leader will use on disk txn sync with followers to if the peer zxid is not in it's in memory commit logs, the code is here: Leader on disk txn sync

Re: ZooKeeper 3.5 blocker issues

What’s needed to turn it off? Do we need a PR or it’s just a config option? Shall we implement a feature switch for that and turn it off by default? Sorry I don’t have too much insight on disk txn sync. Andor > On 2018. Sep 13., at 9:16, Fangmin Lv wrote: > > And to be clear, ZOOKEEPER-2418

Re: ZooKeeper 3.5 blocker issues

And to be clear, ZOOKEEPER-2418 is actually just one case of inconsistency which could caused by on disk txn sync, as I mentioned in a newer JIRA ZOOKEEPER-2846 , the snap sync or txn sync could also leave txns gap in the txn file, which is a

Re: ZooKeeper 3.5 blocker issues

Andor, ZOOKEEPER-3114 is about adding real time digest checking to help detecting inconsistency, it's a new feature with amounts of code change. I'll start upstream it part by part, but I don't expect it's being merged in the next few weeks. So yes, it's a nice to have, but definitely not a block

Re: ZooKeeper 3.5 blocker issues

Fangmin, Sorry, I just noticed that you want to include the consistency fixes in the stable version which is fine. Let’s finish the backports and we’ll be done with them. ZOOKEEPER-3114 is essentially a new feature, I wouldn’t block 3.5 with that. What do you think? Andor > On 2018. Sep

Re: ZooKeeper 3.5 blocker issues

Cool, thanks for the clarification. The updated list is as follows: - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external

Re: ZooKeeper 3.5 blocker issues

Hi Andor, That's the on disk txn feature, which was disabled internally after we found the potentially inconsistent issue. The only solution we have for now is waiting for the new digest checking feature I mentioned in ZOOKEEPER-3114. I think there are some other critical consistent issues we

Re: ZooKeeper 3.5 blocker issues

Hi Jeelani, Thanks for letting me know. I'm happy to remove it from the list to get closer to a stable release. :) What's the feature which can be disabled to avoid data inconsistency? Andor On 09/10/2018 11:33 PM, Mohamed Jeelani wrote: > Thanks Andor for compiling this. Should we be

Re: ZooKeeper 3.5 blocker issues

Thanks Andor for compiling this. Should we be ignoring ZOOKEEPER-2418 as well? This exists in 3.4 as well and the feature can be disabled. We are working on a longer term fix for it in 3.6. Regards, Jeelani On 9/10/18, 5:19 AM, "Andor Molnar" wrote: Fine. I'm happy to ignore

Re: Re: ZooKeeper 3.5 blocker issues

Fine. I'm happy to ignore 1549, 2846 and 2930. Still we have the list of: - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2418 (txnlog diff sync can skip sending some transactions to followers) - ZOOKEEPER-2778 (Potential

回复：Re: Re: ZooKeeper 3.5 blocker issues

waiting for the release of branch3.5 at end of this year!(grin) - 原始邮件 - 发件人：Michael Han 收件人：DevZooKeeper 主题：Re: Re: ZooKeeper 3.5 blocker issues 日期：2018年09月07日 09点24分 I haven't went through the entire list, but looks like lots of the JIRA issues listed in this thread, such as ZOOKEEPER

Re: Re: ZooKeeper 3.5 blocker issues

I haven't went through the entire list, but looks like lots of the JIRA issues listed in this thread, such as ZOOKEEPER-1549, 2846, also affects 3.4 releases. Should we scope these issues out? I think historically the single outstanding blocking issue for a stable 3.5 release is the reconfig

Re: Re: ZooKeeper 3.5 blocker issues

Thanks Maoling! That would be huge help, I appreciate it. Andor

Re: Re: ZooKeeper 3.5 blocker issues

On Mon, Sep 3, 2018 at 4:01 PM 岭秀 wrote: > waiting for the release of 3.5. > I will take the work of ZOOKEEPER-2778 if I have the time > - 原始邮件 - > 发件人：Andor Molnar > 收件人：DevZooKeeper > 主题：Re: ZooKeeper 3.5 blocker issues > 日期：2018年09月03日 18点17分 > > Unfortuna

回复：Re: ZooKeeper 3.5 blocker issues

waiting for the release of 3.5. I will take the work of ZOOKEEPER-2778 if I have the time - 原始邮件 - 发件人：Andor Molnar 收件人：DevZooKeeper 主题：Re: ZooKeeper 3.5 blocker issues 日期：2018年09月03日 18点17分 Unfortunately I haven't got feedback on this blocker list, can we say that we have an agreement

Re: ZooKeeper 3.5 blocker issues

Unfortunately I haven't got feedback on this blocker list, can we say that we have an agreement on it? :) - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1549 (Data inconsistency when follower is receiving a DIFF with a dirty snapshot) - ZOOKEEPER-1818 (Fix don't care

Re: ZooKeeper 3.5 blocker issues

One more item to the list which is very-very important: ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) Andor On Mon, Aug 13, 2018 at 2:09 PM, Andor Molnar wrote: > Looking at the list of Critical issues, I think the following items might > be considered as blockers too: > >

Re: ZooKeeper 3.5 blocker issues

Looking at the list of Critical issues, I think the following items might be considered as blockers too: ZOOKEEPER-2418 (data inconsistency) ZOOKEEPER-2778 ZOOKEEPER-2846 (data inconsistency) ZOOKEEPER-2930 (leader election deadlock) Regards, Andor > On 2018. Aug 13., at 12:38, Andor Molnar