Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Matteo Bertozzi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6290/ --- Review request for zookeeper, Patrick Hunt and Eugene Koontz. Description --

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6290/#review9703 --- Overall looks good. Some comments: /src/java/main/org/apache/zookeep

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Eugene Koontz
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? These sleep()s are present in other SASL

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Patrick Hunt
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Matteo Bertozzi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6290/ --- (Updated Aug. 1, 2012, 8:33 p.m.) Review request for zookeeper, Patrick Hunt and

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Eugene Koontz
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Patrick Hunt
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Eugene Koontz
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Patrick Hunt
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6290/#review9727 --- Looks read to go to me except for the noted issue. /src/java/test/or

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-01 Thread Matteo Bertozzi
> On Aug. 1, 2012, 10:55 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 90 > > > > > > This timeout is too low. Typically we make it the connection t

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-02 Thread Eugene Koontz
> On Aug. 1, 2012, 6:38 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 77 > > > > > > why is this sleep here? > > Eugene Koontz wrote: > These sle

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-02 Thread Patrick Hunt
> On Aug. 1, 2012, 10:55 p.m., Patrick Hunt wrote: > > /src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedServerTest.java, > > line 90 > > > > > > This timeout is too low. Typically we make it the connection t

Re: Review Request: Allow server-side SASL login with JAAS configuration to be programmatically set (rather than only by reading JAAS configuration file)

2012-08-02 Thread Matteo Bertozzi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6290/ --- (Updated Aug. 2, 2012, 9:03 p.m.) Review request for zookeeper, Patrick Hunt and