Re: What path getConfig watchers should receive from ZooKeeper with chroot “/zookeeper/config” ?

2023-04-19 Thread Kezhu Wang
Hi all, Thank you for your information. First, I agree that we should not introduce backward-incompatible changes in patch releases. Second, I have opened pr-1996[1] to fix the `getConfig` watcher path to "/zookeeper/config". Third, apologize for mistakes I made in the initial email. A. It is

Re: What path getConfig watchers should receive from ZooKeeper with chroot “/zookeeper/config” ?

2023-04-16 Thread Enrico Olivelli
Il Ven 14 Apr 2023, 20:47 Chris Nauroth ha scritto: > Thank you for the discussion, Kezhu. > > My take is that the behavior you proposed, with the received path always > /zookeeper/config regardless of chroot, is the correct one. However, it's > hard to know if anyone has coded workarounds on top

Re: What path getConfig watchers should receive from ZooKeeper with chroot “/zookeeper/config” ?

2023-04-14 Thread Chris Nauroth
Thank you for the discussion, Kezhu. My take is that the behavior you proposed, with the received path always /zookeeper/config regardless of chroot, is the correct one. However, it's hard to know if anyone has coded workarounds on top of the current behavior, which would then break if we made the

Re: What path getConfig watchers should receive from ZooKeeper with chroot “/zookeeper/config” ?

2023-04-03 Thread Kezhu Wang
Hi all, Any thoughts on this? Curator has similar issue reported as CURATOR-666[1]. I think it might be worth to get Curator and ZooKeeper behave same in `getConfig`. I replied this also to dev@curator for joint discussion. See my quotes and ZOOKEEPER-4565[2], ZOOKEEPER-4601[3] for context. [1]

What path getConfig watchers should receive from ZooKeeper with chroot “/zookeeper/config” ?

2022-07-27 Thread Kezhu Wang
Hi Devs, Before ZOOKEEPER-4565[1], `ClientCnxn` uses following code to strip chroot: ``` // convert from a server path to a client path if (chrootPath != null) { String serverPath = event.getPath(); if (serverPath.compareTo(chrootPath) == 0) { event.setPath("/"); } else if (se