Re: ZooKeeper and checkstyle

2019-02-12 Thread Enrico Olivelli
Il giorno mar 12 feb 2019 alle ore 10:56 Norbert Kalmar ha scritto: > > There was some discussion about checkstyle a while back, but I can't find > it. Maybe it was on a PR. > We concluded that we have so many violations it doesn't make sense to > activate. But as you suggested, I think the same w

Re: ZooKeeper and checkstyle

2019-02-12 Thread Norbert Kalmar
There was some discussion about checkstyle a while back, but I can't find it. Maybe it was on a PR. We concluded that we have so many violations it doesn't make sense to activate. But as you suggested, I think the same was concluded, that it should be activated on master sooner or later, should onl

ZooKeeper and checkstyle

2019-02-11 Thread Enrico Olivelli
Hi, I did not notice that we already have checkstyle configuration in the ANT build. This is the command ant checkstyle Unfortunately we have hundreds of violations I think it will be a great step to re-enable checkstyle on master after we get a "stable" release of the 3.5 branch. I expect