Re: reconfig APIs

2017-02-11 Thread Michael Han
;>> >>> With respect, the ZooKeeper team has used “alpha” in a novel way >>> that is >>> >>> sowing considerable confusion. I wrote emails about this a while >>> back. >>> >> But, >>> >>> here again, is another

Re: reconfig APIs

2017-02-04 Thread Michael Han
per there will never be a “3.5.2” release. In >> >>> fact, the “-alpha” label is mis-located. The real version is >> >>> “3.5.?-alpha1”, “3.5.?-alpha2”, etc. There’s an important implication >> >> here. >> >>> If a ZooKeeper user who doesn’t foll

Re: reconfig APIs

2017-01-05 Thread Michael Han
; >> here. > >>> If a ZooKeeper user who doesn’t follow the mailing lists, etc. sees > >>> “3.5.2-alpha” and “3.5.3-alpha” they will mentally see these as two > >>> different releases. What ZOOKEEPER-2014 has done is remove an existing > >> API > >&g

Re: reconfig APIs

2016-12-09 Thread Arshad Mohammad
gt; >>> If a ZooKeeper user who doesn’t follow the mailing lists, etc. sees > >>> “3.5.2-alpha” and “3.5.3-alpha” they will mentally see these as two > >>> different releases. What ZOOKEEPER-2014 has done is remove an existing > >> API > >>> from

Re: reconfig APIs

2016-12-08 Thread Jordan Zimmerman
>>> existed). This change violates semantic versioning. For external users, >> the >>> version after “3.5.2” should be “4.x.x” as it has breaking changes. >>> >>>> It's not about style, there were a number of concerns addressed in that >>>> pat

Re: reconfig APIs

2016-12-08 Thread Michael Han
ch. > > > > The auth issues are very real ones. The issues in ZOOKEEPER-2014 can be > > addressed completely without moving the reconfig() methods to a new > class. > > It may be useful to move APIs around for clarity, etc. but these breaking > > changes should be

Re: reconfig APIs

2016-12-08 Thread Patrick Hunt
ed completely without moving the reconfig() methods to a new class. > It may be useful to move APIs around for clarity, etc. but these breaking > changes should be for a version that signals breaking changes - 4.x.x or > something. i.e. moving the reconfig() APIs is orthogonal to the concerns

Re: reconfig APIs

2016-12-08 Thread Jordan Zimmerman
ones. The issues in ZOOKEEPER-2014 can be addressed completely without moving the reconfig() methods to a new class. It may be useful to move APIs around for clarity, etc. but these breaking changes should be for a version that signals breaking changes - 4.x.x or something. i.e. moving the

Re: reconfig APIs

2016-12-07 Thread Patrick Hunt
reconfig() variants into a new > >>>> class? I can see if this was done from the start but you have now > broken > >>>> Curator in a fairly serious non-backward compatible way for a minor > >>>> documenting benefit. Does anyone object to me reversing this? > >>>> > >>>> -Jordan > >>>> > >>>>> On Dec 7, 2016, at 11:37 AM, Jordan Zimmerman < > >>>> jor...@jordanzimmerman.com> wrote: > >>>>> > >>>>> Hi, > >>>>> > >>>>> I was compiling Curator against the ZK master and noticed that the > >>>> reconfig APIs are gone/changed. Can anyone point me at the issues for > >> this > >>>> and/or the discussion why this breaking change was made? > >>>>> > >>>>> -Jordan > >>>> > >>>> > >> > >

Re: reconfig APIs

2016-12-07 Thread Jordan Zimmerman
start but you have now broken >>>> Curator in a fairly serious non-backward compatible way for a minor >>>> documenting benefit. Does anyone object to me reversing this? >>>> >>>> -Jordan >>>> >>>>> On Dec 7, 2016, at 11:37 AM, Jordan Zimmerman < >>>> jor...@jordanzimmerman.com> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I was compiling Curator against the ZK master and noticed that the >>>> reconfig APIs are gone/changed. Can anyone point me at the issues for >> this >>>> and/or the discussion why this breaking change was made? >>>>> >>>>> -Jordan >>>> >>>> >>

Re: reconfig APIs

2016-12-07 Thread Patrick Hunt
benefit. Does anyone object to me reversing this? > >> > >> -Jordan > >> > >>> On Dec 7, 2016, at 11:37 AM, Jordan Zimmerman < > >> jor...@jordanzimmerman.com> wrote: > >>> > >>> Hi, > >>> > >>> I was compiling Curator against the ZK master and noticed that the > >> reconfig APIs are gone/changed. Can anyone point me at the issues for > this > >> and/or the discussion why this breaking change was made? > >>> > >>> -Jordan > >> > >> >

Re: reconfig APIs

2016-12-07 Thread Jordan Zimmerman
>>> On Dec 7, 2016, at 11:37 AM, Jordan Zimmerman < >> jor...@jordanzimmerman.com> wrote: >>> >>> Hi, >>> >>> I was compiling Curator against the ZK master and noticed that the >> reconfig APIs are gone/changed. Can anyone point me at the issues for this >> and/or the discussion why this breaking change was made? >>> >>> -Jordan >> >>

Re: reconfig APIs

2016-12-07 Thread Patrick Hunt
> jor...@jordanzimmerman.com> wrote: > > > > Hi, > > > > I was compiling Curator against the ZK master and noticed that the > reconfig APIs are gone/changed. Can anyone point me at the issues for this > and/or the discussion why this breaking change was made? > > > > -Jordan > >

Re: reconfig APIs

2016-12-07 Thread Jordan Zimmerman
object to me reversing this? -Jordan > On Dec 7, 2016, at 11:37 AM, Jordan Zimmerman > wrote: > > Hi, > > I was compiling Curator against the ZK master and noticed that the reconfig > APIs are gone/changed. Can anyone point me at the issues for this and/or the > disc

reconfig APIs

2016-12-07 Thread Jordan Zimmerman
Hi, I was compiling Curator against the ZK master and noticed that the reconfig APIs are gone/changed. Can anyone point me at the issues for this and/or the discussion why this breaking change was made? -Jordan