[b2g] Ignore blanks when reviewing a patch

2013-03-16 Thread Salvador de la Puente González
Hello everybody If you don't know there is an option to ignore white spaces when comparing commits in GitHub and git, please continue reading: Yesterday I found a commentary in one of my PR saying a patch involves a "fairly large merge conflicts on v1.0.1" [1]. If you do something like: git f

Re: [b2g] Ignore blanks when reviewing a patch

2013-03-16 Thread Axel Hecht
Salvador, you may have provided a UI hook to reduce the diff, but you're not fixing git annotate. Fixing software often requires version history to tell why a piece of code is what it is, and now the only reason why that code is what it is is... your opinion on whitespace. That's sad, and pe

Re: [b2g] Ignore blanks when reviewing a patch

2013-03-16 Thread Andrew Sutherland
On 03/16/2013 09:26 AM, Axel Hecht wrote: Salvador, you may have provided a UI hook to reduce the diff, but you're not fixing git annotate. My personal experience in mozilla-central and comm-central was that holding blame/annotate sacred provided a lot of stop energy to improving the state of

Re: [b2g] Ignore blanks when reviewing a patch

2013-03-16 Thread Gavin Sharp
On Sat, Mar 16, 2013 at 12:07 PM, Andrew Sutherland wrote: > My personal experience in mozilla-central and comm-central was that holding > blame/annotate sacred provided a lot of stop energy to improving the state > of code, leaving the code generally worse off. Indeed. Determining the original s

Re: [b2g] Ignore blanks when reviewing a patch

2013-03-18 Thread Jed Davis
On Sat, Mar 16, 2013 at 01:33:42PM -0700, Gavin Sharp wrote: > On Sat, Mar 16, 2013 at 12:07 PM, Andrew Sutherland > wrote: > > My personal experience in mozilla-central and comm-central was that holding > > blame/annotate sacred provided a lot of stop energy to improving the state > > of code, le