In message
, Rick Macklem writes:
> On Tue, Apr 4, 2023 at 12:31=E2=80=AFPM Cy Schubert com> wrote:
> >
> > CAUTION: This email originated from outside of the University of Guelph. =
> Do not click links or open attachments unless you recognize the sender and =
> know the content is safe. If in d
As requested by rpokala, D39418 and D39419 have been submitted.
Again, I am not the author of these. Only the curator.
We can continue our discussion there.
--
Cheers,
Cy Schubert
FreeBSD UNIX: Web: https://FreeBSD.org
NTP: Web: https://nwtime.org
; > Date: Tuesday, April 4, 2023 at 09:18
> > To: Martin Matuska mailto:m...@freebsd.org>>
> > Cc: Rick Macklem mailto:rick.mack...@gmail.com>>,
> > Mateusz Guzik mailto:mjgu...@gmail.com>>,
> > mailto:src-committ...@freebsd.org>>,
> > m
I agree that these are three individual fixes.
1.) pass ap->a_outcred instead of ap->a_fsizetd->td_ucred to
zfs_clone_range()
I am ok with this, the way the argument is subsequently used it should
be ap->a_outcred which is intended for the write.
2.) do a vn_generic_copy_file_range() in case
On 4/4/23, Cy Schubert wrote:
> On Tue, 4 Apr 2023 12:30:54 -0700
> Cy Schubert wrote:
>
>> On Tue, 4 Apr 2023 17:54:28 +
>> "Pokala, Ravi" wrote:
>>
>> > Cy,
>> >
>> > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and
>> > then later has a check for 'if (!done_outvp)'
On Tue, 4 Apr 2023 12:30:54 -0700
Cy Schubert wrote:
> On Tue, 4 Apr 2023 17:54:28 +
> "Pokala, Ravi" wrote:
>
> > Cy,
> >
> > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and
> > then later has a check for 'if (!done_outvp)'. Since there is no
> > intervening pla
ilto:m...@freebsd.org>>
> Cc: Rick Macklem mailto:rick.mack...@gmail.com>>,
> Mateusz Guzik mailto:mjgu...@gmail.com>>,
> mailto:src-committ...@freebsd.org>>,
> mailto:dev-commits-src-all@freebsd.org>>,
> mailto:dev-commits-src-m...@freebsd.org>
In message
, Mateusz Guzik writes:
> can you please post a review
I could but I didn't write any of it. Rick Macklem and Martin Matuska wrote
it. My patch was for discussion only.
Martin and Rick, do you mind if I post this as a review. It should probably
be two, maybe three separate commits,
can you please post a review
On 4/4/23, Cy Schubert wrote:
> The previously posted patch containing the following fixes all
> regressions discussed so far:
>
> - Rick's fix null ap->a_fsizetd NULL pointer derefernce
> - Rick's call vn_generic_copy_file_range() when block_cloning is
> disabled
>
To: Martin Matuska mailto:m...@freebsd.org>>
Cc: Rick Macklem mailto:rick.mack...@gmail.com>>,
Mateusz Guzik mailto:mjgu...@gmail.com>>,
mailto:src-committ...@freebsd.org>>,
mailto:dev-commits-src-all@freebsd.org>>,
mailto:dev-commits-src-m...@freebsd.org>>
Subject: R
The previously posted patch containing the following fixes all
regressions discussed so far:
- Rick's fix null ap->a_fsizetd NULL pointer derefernce
- Rick's call vn_generic_copy_file_range() when block_cloning is
disabled
- Martin's call vn_generic_copy_file_range() when any other error
resul
On Tue, 4 Apr 2023 17:30:25 +0200
Martin Matuska wrote:
> So I am now a little bit confused - what is the consensus? :-)
My exmh email client made a mess of that. Let's try this again.
Rick has posted a patch. Your patch should also be incorporated to work
around other EXDEV errors, but a few
Rick has posted a patch. Your patch should also be incorporated to work
around other EXDEV errors, but a few lines earlier so it is protected by
the lock.
There were a couple of typos in Rick's patch (a missing keystroke;
s/ojset/objset/).
The patch (Rick's null pointer dereference fix, Rick's
So I am now a little bit confused - what is the consensus? :-)
On 4. 4. 2023 17:26, Rick Macklem wrote:
On Tue, Apr 4, 2023 at 7:38 AM Mateusz Guzik wrote:
CAUTION: This email originated from outside of the University of Guelph. Do not
click links or open attachments unless you recognize the
In message
, Rick Macklem writes:
> On Tue, Apr 4, 2023 at 7:38=E2=80=AFAM Mateusz Guzik wr=
> ote:
> >
> > CAUTION: This email originated from outside of the University of Guelph. =
> Do not click links or open attachments unless you recognize the sender and =
> know the content is safe. If in d
On Tue, Apr 4, 2023 at 8:02 AM Cy Schubert wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do
> not click links or open attachments unless you recognize the sender and know
> the content is safe. If in doubt, forward suspicious emails to
> ith...@uoguelph.ca
On Tue, Apr 4, 2023 at 7:38 AM Mateusz Guzik wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do
> not click links or open attachments unless you recognize the sender and know
> the content is safe. If in doubt, forward suspicious emails to
> ith...@uoguelph.c
In message
, Mateusz Guzik writes:
> On 4/4/23, Cy Schubert wrote:
> > In message <202304041145.334bjx6l035...@gitrepo.freebsd.org>, Martin
> > Matuska wr
> > ites:
> >> The branch main has been updated by mm:
> >>
> >> URL:
> >> https://cgit.FreeBSD.org/src/commit/?id=8ee579abe09ec1fe15c588fc9a0
On Tue, Apr 4, 2023 at 7:17 AM Cy Schubert wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do
> not click links or open attachments unless you recognize the sender and know
> the content is safe. If in doubt, forward suspicious emails to
> ith...@uoguelph.ca
On 4/4/23, Cy Schubert wrote:
> In message <202304041145.334bjx6l035...@gitrepo.freebsd.org>, Martin
> Matuska wr
> ites:
>> The branch main has been updated by mm:
>>
>> URL:
>> https://cgit.FreeBSD.org/src/commit/?id=8ee579abe09ec1fe15c588fc9a08370b
>> 83b81cd6
>>
>> commit 8ee579abe09ec1fe15c58
In message <202304041145.334bjx6l035...@gitrepo.freebsd.org>, Martin
Matuska wr
ites:
> The branch main has been updated by mm:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=8ee579abe09ec1fe15c588fc9a08370b
> 83b81cd6
>
> commit 8ee579abe09ec1fe15c588fc9a08370b83b81cd6
> Author: Martin Matu
The branch main has been updated by mm:
URL:
https://cgit.FreeBSD.org/src/commit/?id=8ee579abe09ec1fe15c588fc9a08370b83b81cd6
commit 8ee579abe09ec1fe15c588fc9a08370b83b81cd6
Author: Martin Matuska
AuthorDate: 2023-04-04 11:40:41 +
Commit: Martin Matuska
CommitDate: 2023-04-04 11:43
22 matches
Mail list logo
