The branch main has been updated by cy:
URL:
https://cgit.FreeBSD.org/src/commit/?id=f44e67d120ad78ef7894241b519ee79fd190a16e
commit f44e67d120ad78ef7894241b519ee79fd190a16e
Merge: 1e811efbc591 d60fa10fd872
Author: Cy Schubert
AuthorDate: 2021-02-10 04:25:05 +
Commit: Cy Schubert
C
The branch main has been updated by cy:
URL:
https://cgit.FreeBSD.org/src/commit/?id=1e811efbc591699b872bea42b9de419c373199df
commit 1e811efbc591699b872bea42b9de419c373199df
Author: Cy Schubert
AuthorDate: 2021-02-10 01:13:01 +
Commit: Cy Schubert
CommitDate: 2021-02-10 01:18:25 +0
On Tue, Feb 9, 2021 at 3:17 PM John Baldwin wrote:
> On 2/9/21 6:53 AM, Alexey Dokuchaev wrote:
> > On Tue, Feb 09, 2021 at 02:41:15PM +0100, Mateusz Guzik wrote:
> >> ...
> >> More, if reviews were mandatory, I would expect their quality to go
> >> down even further, making them even less likely
The branch main has been updated by tuexen:
URL:
https://cgit.FreeBSD.org/src/commit/?id=f25266bee7dafb10f03e06537c8127cc17335bed
commit f25266bee7dafb10f03e06537c8127cc17335bed
Author: Michael Tuexen
AuthorDate: 2021-02-09 22:35:55 +
Commit: Michael Tuexen
CommitDate: 2021-02-09 2
The branch main has been updated by dim:
URL:
https://cgit.FreeBSD.org/src/commit/?id=51af03328755c9095e94d20858a8d10acfe412ae
commit 51af03328755c9095e94d20858a8d10acfe412ae
Author: Dimitry Andric
AuthorDate: 2021-02-09 22:37:08 +
Commit: Dimitry Andric
CommitDate: 2021-02-09 22:3
On 2/9/21 6:53 AM, Alexey Dokuchaev wrote:
On Tue, Feb 09, 2021 at 02:41:15PM +0100, Mateusz Guzik wrote:
...
More, if reviews were mandatory, I would expect their quality to go
down even further, making them even less likely to prevent breakage.
Exactly that. In fact, the good reviews are ty
The branch main has been updated by jrtc27:
URL:
https://cgit.FreeBSD.org/src/commit/?id=9c6954329a9285547881ddd60e393b7c55ed30c4
commit 9c6954329a9285547881ddd60e393b7c55ed30c4
Author: Jessica Clarke
AuthorDate: 2021-02-09 21:40:24 +
Commit: Jessica Clarke
CommitDate: 2021-02-09 2
The branch main has been updated by dim:
URL:
https://cgit.FreeBSD.org/src/commit/?id=ac76bc1145dd7f4476e5d982ce8f355f71015713
commit ac76bc1145dd7f4476e5d982ce8f355f71015713
Author: Dimitry Andric
AuthorDate: 2021-02-09 21:06:51 +
Commit: Dimitry Andric
CommitDate: 2021-02-09 21:0
On Tue, Feb 09, 2021 at 08:42:38PM +0100, Mateusz Guzik wrote:
> Things like this are best sorted out with atomic_store, otherwise you
> may fall victim of various compiler mischief (even if it happens to be
> harmless for the time being).
>
> iow all ->staleness accesses should be converted to at
Things like this are best sorted out with atomic_store, otherwise you
may fall victim of various compiler mischief (even if it happens to be
harmless for the time being).
iow all ->staleness accesses should be converted to atomic_*.
grep finds this in ng_bridge_timeout:
i
The branch main has been updated by donner:
URL:
https://cgit.FreeBSD.org/src/commit/?id=011b7317dbb5038a95b9b4fca050325a62f3991e
commit 011b7317dbb5038a95b9b4fca050325a62f3991e
Author: Lutz Donnerhacke
AuthorDate: 2021-02-09 11:32:46 +
Commit: Lutz Donnerhacke
CommitDate: 2021-02-
On Tue, 9 Feb 2021 at 08:41, Mateusz Guzik wrote:
>
> Examples from recent past (all fixed):
I don't think the examples are all good ones - several are failures of
our tooling, not of code review. The limited review effort we have
shouldn't be spent pointing out style(9) violations or build-break
The branch main has been updated by donner:
URL:
https://cgit.FreeBSD.org/src/commit/?id=ccf4cd2e7830394467d5f6cf546ab453f9657b69
commit ccf4cd2e7830394467d5f6cf546ab453f9657b69
Author: Lutz Donnerhacke
AuthorDate: 2021-02-08 21:36:46 +
Commit: Lutz Donnerhacke
CommitDate: 2021-02-
The branch main has been updated by freqlabs:
URL:
https://cgit.FreeBSD.org/src/commit/?id=e9d419a05357036ea2fd37218d853d2c713d55cc
commit e9d419a05357036ea2fd37218d853d2c713d55cc
Author: Antonio Russo
AuthorDate: 2021-02-08 17:15:05 +
Commit: Ryan Moeller
CommitDate: 2021-02-09 17
The branch main has been updated by arichardson:
URL:
https://cgit.FreeBSD.org/src/commit/?id=81c3f64110bb76e24d6062eafd7206c10f676d6f
commit 81c3f64110bb76e24d6062eafd7206c10f676d6f
Author: Alex Richardson
AuthorDate: 2021-01-19 11:35:07 +
Commit: Alex Richardson
CommitDate: 2021-
The branch main has been updated by mjg:
URL:
https://cgit.FreeBSD.org/src/commit/?id=39e0c3f686387605591f8f646ceec53613619525
commit 39e0c3f686387605591f8f646ceec53613619525
Author: Mateusz Guzik
AuthorDate: 2021-02-09 16:06:27 +
Commit: Mateusz Guzik
CommitDate: 2021-02-09 16:09:
On 2/9/21, Jessica Clarke wrote:
> Here's your review after reading through it for <5 minutes today:
>
> On 8 Feb 2021, at 19:15, Mateusz Guzik wrote:
>> +leaq(%r11,%r8),%rcx
>> +notq%r11
>> +andq%r11,%rcx
>> +andq%r9,%rcx
>> ...
>> +leaq(%r11,%r8),%rcx
>>
Here's your review after reading through it for <5 minutes today:
On 8 Feb 2021, at 19:15, Mateusz Guzik wrote:
> + leaq(%r11,%r8),%rcx
> + notq%r11
> + andq%r11,%rcx
> + andq%r9,%rcx
> ...
> + leaq(%r11,%r8),%rcx
> + notq%r11
> + andq%rcx,%
The branch main has been updated by mjg:
URL:
https://cgit.FreeBSD.org/src/commit/?id=b49a0db6628e6f953504ebc8712ed582471ccd05
commit b49a0db6628e6f953504ebc8712ed582471ccd05
Author: Mateusz Guzik
AuthorDate: 2021-02-09 15:18:58 +
Commit: Mateusz Guzik
CommitDate: 2021-02-09 15:23:
On Tue, Feb 09, 2021 at 02:41:15PM +0100, Mateusz Guzik wrote:
> ...
> More, if reviews were mandatory, I would expect their quality to go
> down even further, making them even less likely to prevent breakage.
Exactly that. In fact, the good reviews are typically coming from
people who care. But
On Tue, Feb 9, 2021 at 3:15 AM Mateusz Guzik wrote:
>
> The branch main has been updated by mjg:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=81e074d57dfcd86f152e2848dc44b77087ee7a2d
>
> commit 81e074d57dfcd86f152e2848dc44b77087ee7a2d
> Author: Mateusz Guzik
> AuthorDate: 2021-02-07 19
On 2/9/21, Jessica Clarke wrote:
>> On 8 Feb 2021, at 23:13, Kevin Bowling wrote:
>>
>> FreeBSD does not require pre-commit approval unless called out
>> specifically. Are you volunteering to review the changes, and if so
>> where is your guidance? These messages are otherwise unhelpful.
>
> It
The branch main has been updated by mmel:
URL:
https://cgit.FreeBSD.org/src/commit/?id=ec090f4a67654fa541e6d97fd5f74d3f66c1c0d0
commit ec090f4a67654fa541e6d97fd5f74d3f66c1c0d0
Author: Michal Meloun
AuthorDate: 2021-02-09 10:36:36 +
Commit: Michal Meloun
CommitDate: 2021-02-09 11:53
The branch main has been updated by tsoome:
URL:
https://cgit.FreeBSD.org/src/commit/?id=96bef2053a87c8d01ce08ea88857e4657489c8e7
commit 96bef2053a87c8d01ce08ea88857e4657489c8e7
Author: Toomas Soome
AuthorDate: 2021-02-08 18:49:09 +
Commit: Toomas Soome
CommitDate: 2021-02-09 11:45
The branch main has been updated by tsoome:
URL:
https://cgit.FreeBSD.org/src/commit/?id=a26f7358583174f2fe0df3e979f7b8b02069278c
commit a26f7358583174f2fe0df3e979f7b8b02069278c
Author: Toomas Soome
AuthorDate: 2021-02-08 22:34:47 +
Commit: Toomas Soome
CommitDate: 2021-02-09 11:46
On Mon, Feb 08, 2021 at 07:48:22PM +0100, Daniel Ebdrup Jensen wrote:
On Mon, Feb 08, 2021 at 09:22:25AM -0600, Kyle Evans wrote:
On Mon, Feb 8, 2021 at 9:07 AM Eugene Grosbein wrote:
08.02.2021 21:58, Kyle Evans wrote:
kld_list cannot do that.
Huh? kld_list accepts a full pathname, which
08.02.2021 22:22, Kyle Evans wrote:
> It's OK to call out the more
> common case for folks, but this feels a lot more absolute than it
> needs to be.
Also, the loader is capable of loading compressed .ko files that may be
important
for space-constrained ("embedded") systems. AFAIR, kldload canno
27 matches
Mail list logo
