Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 16, 2023, at 10:40, Mark Millard wrote: > On Apr 16, 2023, at 01:34, Mark Millard wrote: > >> On Apr 15, 2023, at 19:13, Mark Millard wrote: >> >>> A general question is all for this message. >>> >>> So far no commit to FeeeBSD's main seems to be >>> analogous to the content of: >>>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 16, 2023, at 01:34, Mark Millard wrote: > On Apr 15, 2023, at 19:13, Mark Millard wrote: > >> A general question is all for this message. >> >> So far no commit to FeeeBSD's main seems to be >> analogous to the content of: >> >> https://github.com/openzfs/zfs/pull/14739/files >> >> Af

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 19:13, Mark Millard wrote: > A general question is all for this message. > > So far no commit to FeeeBSD's main seems to be > analogous to the content of: > > https://github.com/openzfs/zfs/pull/14739/files > > After my existing poudriere bulk test finishes, > should I avoi

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 21:31, Mark Millard wrote: > On Apr 15, 2023, at 17:27, Mark Millard wrote: > >> On Apr 15, 2023, at 15:49, Mark Millard wrote: >> >>> . . . (Mostly written as I progressed but some material later inserted into/around previously written material.) >>>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 17:27, Mark Millard wrote: > On Apr 15, 2023, at 15:49, Mark Millard wrote: > >> . . . >>> >>> >>> (Mostly written as I progressed but some material later >>> inserted into/around previously written material.) >>> >>> Summary: >>> >>> As stands, it looks like reverting t

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

A general question is all for this message. So far no commit to FeeeBSD's main seems to be analogous to the content of: https://github.com/openzfs/zfs/pull/14739/files After my existing poudriere bulk test finishes, should I avoid having the content of that change in place for future testing? Vs

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 15:49, Mark Millard wrote: > . . . >> >> >> (Mostly written as I progressed but some material later >> inserted into/around previously written material.) >> >> Summary: >> >> As stands, it looks like reverting the dnode_is_dirty >> code is what fixes the corruptions tha

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 15:33, Mark Millard wrote: > On Apr 15, 2023, at 13:30, Mateusz Guzik wrote: > >> On 4/15/23, FreeBSD User wrote: >>> Am Sat, 15 Apr 2023 07:36:25 -0700 >>> Cy Schubert schrieb: >>> In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, FreeBSD Us

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 13:30, Mateusz Guzik wrote: > On 4/15/23, FreeBSD User wrote: >> Am Sat, 15 Apr 2023 07:36:25 -0700 >> Cy Schubert schrieb: >> >>> In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, >>> FreeBSD Us >>> er writes: Am Thu, 13 Apr 2023 22:18:04 -0700

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/15/23, FreeBSD User wrote: > Am Sat, 15 Apr 2023 07:36:25 -0700 > Cy Schubert schrieb: > >> In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, >> FreeBSD Us >> er writes: >> > Am Thu, 13 Apr 2023 22:18:04 -0700 >> > Mark Millard schrieb: >> > >> > > On Apr 13, 2023, at 21:

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 11:07, Cy Schubert wrote: > In message <5a47f62d-0e78-4c3e-84c0-45eeb03c7...@yahoo.com>, Mark Millard > write > s: >> On Apr 15, 2023, at 07:36, Cy Schubert = >> wrote: >> >>> In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>,=20= >> >>> FreeBSD Us >>> er

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message <5a47f62d-0e78-4c3e-84c0-45eeb03c7...@yahoo.com>, Mark Millard write s: > On Apr 15, 2023, at 07:36, Cy Schubert = > wrote: > > > In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>,=20= > > > FreeBSD Us > > er writes: > >> Am Thu, 13 Apr 2023 22:18:04 -0700 > >> Mark M

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 15, 2023, at 07:36, Cy Schubert wrote: > In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, > FreeBSD Us > er writes: >> Am Thu, 13 Apr 2023 22:18:04 -0700 >> Mark Millard schrieb: >> >>> On Apr 13, 2023, at 21:44, Charlie Li wrote: >>> Mark Millard wrote: >>>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Sat, 15 Apr 2023 18:07:34 +0200 Florian Smeets wrote: > On 15.04.23 17:51, FreeBSD User wrote: > > Am Sat, 15 Apr 2023 07:36:25 -0700 > > Cy Schubert schrieb: > >> > >> With an up-to-date tree + pjd@'s "Fix data corruption when cloning embedded > >> blocks. #14739" patch I didn't have any i

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message <20230415175218.777d0...@thor.intern.walstatt.dynvpn.de>, FreeBSD Us er writes: > Am Sat, 15 Apr 2023 07:36:25 -0700 > Cy Schubert schrieb: > > > In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, > > FreeBSD Us > > er writes: > > > Am Thu, 13 Apr 2023 22:18:04 -0700

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 15.04.23 17:51, FreeBSD User wrote: Am Sat, 15 Apr 2023 07:36:25 -0700 Cy Schubert schrieb: With an up-to-date tree + pjd@'s "Fix data corruption when cloning embedded blocks. #14739" patch I didn't have any issues, except for email messages with corruption in my sent directory, nowhere els

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Am Sat, 15 Apr 2023 07:36:25 -0700 Cy Schubert schrieb: > In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, > FreeBSD Us > er writes: > > Am Thu, 13 Apr 2023 22:18:04 -0700 > > Mark Millard schrieb: > > > > > On Apr 13, 2023, at 21:44, Charlie Li wrote: > > > > > > > Ma

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message <20230415115452.08911...@thor.intern.walstatt.dynvpn.de>, FreeBSD Us er writes: > Am Thu, 13 Apr 2023 22:18:04 -0700 > Mark Millard schrieb: > > > On Apr 13, 2023, at 21:44, Charlie Li wrote: > > > > > Mark Millard wrote: > > >> FYI: in my original report for a context that has nev

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Am Thu, 13 Apr 2023 22:18:04 -0700 Mark Millard schrieb: > On Apr 13, 2023, at 21:44, Charlie Li wrote: > > > Mark Millard wrote: > >> FYI: in my original report for a context that has never had > >> block_cloning enabled, I reported BOTH missing files and > >> file content corruption in the

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Thu, Apr 13, 2023 at 06:48:14PM -0400, Charlie Li wrote: > Shawn Webb wrote: > > Does the ZFS project have some sort of automated testing to catch > > data-gobbling, pool killing bugs? It seems like this would have been > > caught with some CI/CD stress testing automation scripts. > > > I can't

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 13, 2023, at 21:44, Charlie Li wrote: > Mark Millard wrote: >> FYI: in my original report for a context that has never had >> block_cloning enabled, I reported BOTH missing files and >> file content corruption in the poudriere-devel bulk build >> testing. This predates: >> https://people.f

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Mark Millard wrote: FYI: in my original report for a context that has never had block_cloning enabled, I reported BOTH missing files and file content corruption in the poudriere-devel bulk build testing. This predates: https://people.freebsd.org/~pjd/patches/brt_revert.patch but had the changes

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 13, 2023, at 21:27, Charlie Li wrote: > > Pawel Jakub Dawidek wrote: >> On 4/14/23 09:23, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned bl

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Pawel Jakub Dawidek wrote: On 4/14/23 09:23, Charlie Li wrote: Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23 09:23, Charlie Li wrote: Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and existing

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23, Charlie Li wrote: > Pawel Jakub Dawidek wrote: >> On 4/14/23 07:52, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools.

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Pawel Jakub Dawidek wrote: Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and existing cloned blocks freed. It does not h

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Pawel Jakub Dawidek wrote: On 4/14/23 07:52, Charlie Li wrote: Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that bl

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23 07:52, Charlie Li wrote: Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that block_cloning was not the cau

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23 07:40, Pawel Jakub Dawidek wrote: On 4/13/23 22:56, Cy Schubert wrote: I'm in the process of building a branch reverting the merge altogether and will test it on my sandbox machine later today. Cy, thank you for your testing and patience so far. I'm working on a patch to revert b

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23 07:36, Pawel Jakub Dawidek wrote: On 4/13/23 23:05, Shawn Webb wrote: I've learned over the years downstream that it's not really my place to tell upstream what to do or how to do it. However, I think given the seriousness of this, upstream might do well to revert the commit until a s

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Pawel Jakub Dawidek wrote: thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who already upgraded their pools. Testing with mjg@ earlier today revealed that block_cloning was not the cause of poudriere bulk build (and simil

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Shawn Webb wrote: Does the ZFS project have some sort of automated testing to catch data-gobbling, pool killing bugs? It seems like this would have been caught with some CI/CD stress testing automation scripts. I can't speak about how the OpenZFS project does things, but this particular corrupt

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/13/23 22:56, Cy Schubert wrote: I'm in the process of building a branch reverting the merge altogether and will test it on my sandbox machine later today. Cy, thank you for your testing and patience so far. I'm working on a patch to revert block cloning without affecting people who alrea

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/13/23 23:05, Shawn Webb wrote: I've learned over the years downstream that it's not really my place to tell upstream what to do or how to do it. However, I think given the seriousness of this, upstream might do well to revert the commit until a solid fix is in place. Upstream might want to c

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Thu, Apr 13, 2023 at 06:56:35AM -0700, Cy Schubert wrote: > In message om> > , Mateusz Guzik writes: > > On 4/13/23, Cy Schubert wrote: > > > On Thu, 13 Apr 2023 19:54:42 +0900 > > > Pawe=C5=82 Jakub Dawidek wrote: > > > > > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote= > > : > > >> > > >

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message , Mateusz Guzik writes: > On 4/13/23, Cy Schubert wrote: > > On Thu, 13 Apr 2023 19:54:42 +0900 > > Pawe=C5=82 Jakub Dawidek wrote: > > > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote= > : > >> > > >> > =EF=BB=BFIn message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Sc= > huber

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/13/23, Cy Schubert wrote: > On Thu, 13 Apr 2023 19:54:42 +0900 > Paweł Jakub Dawidek wrote: > >> On Apr 13, 2023, at 16:10, Cy Schubert wrote: >> > >> > In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert >> > writes: >> > In message <20230413064252.1e5c1...@slippy.cwsent.c

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Thu, 13 Apr 2023 19:54:42 +0900 Paweł Jakub Dawidek wrote: > On Apr 13, 2023, at 16:10, Cy Schubert wrote: > > > > In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert writes: > > In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > >> In message , Ma

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 13, 2023, at 04:04, Charlie Li wrote: > Paweł Jakub Dawidek wrote: >> Can you please try this patch: >> >> Unfortunately I don’t see how this can happen with block cloning disabled. > This patch made no difference in poudriere; corruption still r

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Paweł Jakub Dawidek wrote: Can you please try this patch: Unfortunately I don’t see how this can happen with block cloning disabled. This patch made no difference in poudriere; corruption still rolled in. -- Charlie Li …nope, still don't have an exi

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: Have you tried poudriere bulk -C or -c ? Some packages may be corrupt. This was entirely with bulk -c. Because this pool has -o compatibility=openzfs-2.1-freebsd, I was able to revert this entire series and the problems went away. -- Charlie Li …nope, still don't have an

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 13, 2023, at 16:10, Cy Schubert wrote:In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert writes:In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes:In message , Mark Millard writes:[This just puts my prior reply's material into Cy'sadjusted resend of

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Wed, Apr 12, 2023 at 10:37:59AM -0700, Cy Schubert wrote: > > Like Kirk McKusick has reiterated many times, back in the old days > people didn't trust EXT*FS because of the data corruption experienced. > Sadly ZFS will need to earn people's trust back again. This is > unfortunate. Correcti

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Apr 12, 2023, at 23:52, Alexander Leidinger wrote: > Quoting Mark Millard (from Wed, 12 Apr 2023 22:28:13 > -0700): > >> A fair number of errors are of the form: the build >> installing a previously built package for use in the >> builder but later the builder can not find some file >> from

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message <20230413070426.8a54f...@slippy.cwsent.com>, Cy Schubert writes: > In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > > In message , Mark Millard > > write > > s: > > > [This just puts my prior reply's material into Cy's > > > adjusted resend of the original.

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message <20230413064252.1e5c1...@slippy.cwsent.com>, Cy Schubert writes: > In message , Mark Millard > write > s: > > [This just puts my prior reply's material into Cy's > > adjusted resend of the original. The To/Cc should > > be coomplete this time.] > > > > On Apr 12, 2023, at 22:52, Cy Schu

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Quoting Mark Millard (from Wed, 12 Apr 2023 22:28:13 -0700): A fair number of errors are of the form: the build installing a previously built package for use in the builder but later the builder can not find some file from the package's installation. As a data point, last year I had such is

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message , Mark Millard write s: > [This just puts my prior reply's material into Cy's > adjusted resend of the original. The To/Cc should > be coomplete this time.] > > On Apr 12, 2023, at 22:52, Cy Schubert = > wrote: > > > In message , Mark = > Millard=20 > > write > > s: > >> From: Charlie

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

[This just puts my prior reply's material into Cy's adjusted resend of the original. The To/Cc should be coomplete this time.] On Apr 12, 2023, at 22:52, Cy Schubert wrote: > In message , Mark Millard > write > s: >> From: Charlie Li wrote on >> Date: Wed, 12 Apr 2023 20:11:16 UTC : >> >>> Ch

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

From: Cy Schubert wrote on Date: Thu, 13 Apr 2023 05:47:33 UTC : > On Wed, 12 Apr 2023 22:28:13 -0700 > Mark Millard wrote: > > > From: Charlie Li wrote on > > Date: Wed, 12 Apr 2023 20:11:16 UTC : > > > > > Charlie Li wrote: > > > > Mateusz Guzik wrote: > > > >> can you please test poudrie

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message , Mark Millard write s: > From: Charlie Li wrote on > Date: Wed, 12 Apr 2023 20:11:16 UTC : > > > Charlie Li wrote: > > > Mateusz Guzik wrote: > > >> can you please test poudriere with > > >> https://github.com/openzfs/zfs/pull/14739/files > > >> > > > After applying, on the md(4)-back

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Wed, 12 Apr 2023 22:28:13 -0700 Mark Millard wrote: > From: Charlie Li wrote on > Date: Wed, 12 Apr 2023 20:11:16 UTC : > > > Charlie Li wrote: > > > Mateusz Guzik wrote: > > >> can you please test poudriere with > > >> https://github.com/openzfs/zfs/pull/14739/files > > >> > > > After

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Wed, 12 Apr 2023 16:11:16 -0400 Charlie Li wrote: > Charlie Li wrote: > > Mateusz Guzik wrote: > >> can you please test poudriere with > >> https://github.com/openzfs/zfs/pull/14739/files > >> > > After applying, on the md(4)-backed pool regardless of block_cloning, > > the cy@ `cp -R` te

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

From: Charlie Li wrote on Date: Wed, 12 Apr 2023 20:11:16 UTC : > Charlie Li wrote: > > Mateusz Guzik wrote: > >> can you please test poudriere with > >> https://github.com/openzfs/zfs/pull/14739/files > >> > > After applying, on the md(4)-backed pool regardless of block_cloning, > > the cy@ `cp

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Wed, 12 Apr 2023 15:01:15 -0400 Charlie Li wrote: > Mateusz Guzik wrote: > > can you please test poudriere with > > https://github.com/openzfs/zfs/pull/14739/files > > > After applying, on the md(4)-backed pool regardless of block_cloning, > the cy@ `cp -R` test reports no differing (ie co

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Charlie Li wrote: Mateusz Guzik wrote: can you please test poudriere with https://github.com/openzfs/zfs/pull/14739/files After applying, on the md(4)-backed pool regardless of block_cloning, the cy@ `cp -R` test reports no differing (ie corrupted) files. Will report back on poudriere results

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Mateusz Guzik wrote: can you please test poudriere with https://github.com/openzfs/zfs/pull/14739/files After applying, on the md(4)-backed pool regardless of block_cloning, the cy@ `cp -R` test reports no differing (ie corrupted) files. Will report back on poudriere results (no block_cloning)

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 12, 2023 10:28:26 AM PDT, Mateusz Guzik wrote: >can you please test poudriere with >https://github.com/openzfs/zfs/pull/14739/files > >On 4/12/23, Charlie Li wrote: >> Charlie Li wrote: >>> Cy Schubert wrote: On April 12, 2023 8:51:09 AM PDT, Charlie Li wrote: > Cy Schuber

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 12, 2023 10:41:17 AM PDT, Mark Millard wrote: >From: Cy Schubert wrote on >Date: Wed, 12 Apr 2023 16:54:59 UTC : > >> . . . >> >> You need to copy from/to the same dataset to reproduce the problem. Copying >> from a source dataset to a different dataset will avoid block_cloning. > > >h

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: This is because your pool has previously corrupted blocks. Even when you backed up the old pool, created a new pool without block_cloning and restored your data, because the backup contained corrupted blocks from your old pool, they were restored as is. ZFS can only fix corr

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

[Just a resend to fix a typo in the CC.] From: Cy Schubert wrote on Date: Wed, 12 Apr 2023 16:54:59 UTC : > . . . > > You need to copy from/to the same dataset to reproduce the problem. Copying > from a source dataset to a different dataset will avoid block_cloning. https://openzfs.github.io

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

From: Cy Schubert wrote on Date: Wed, 12 Apr 2023 16:54:59 UTC : > . . . > > You need to copy from/to the same dataset to reproduce the problem. Copying > from a source dataset to a different dataset will avoid block_cloning. https://openzfs.github.io/openzfs-docs/man/7/zpool-features.7.html

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 12, 2023 10:22:25 AM PDT, Charlie Li wrote: >Charlie Li wrote: >> Cy Schubert wrote: >>> On April 12, 2023 8:51:09 AM PDT, Charlie Li wrote: Cy Schubert wrote: > I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, > and other writes I can easily recreat

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

can you please test poudriere with https://github.com/openzfs/zfs/pull/14739/files On 4/12/23, Charlie Li wrote: > Charlie Li wrote: >> Cy Schubert wrote: >>> On April 12, 2023 8:51:09 AM PDT, Charlie Li >>> wrote: Cy Schubert wrote: > I have a "sandhbox" pool, called t, used for /usr/o

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Charlie Li wrote: Cy Schubert wrote: On April 12, 2023 8:51:09 AM PDT, Charlie Li wrote: Cy Schubert wrote: I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, and other writes I can easily recreate on my laptop. Here are the results of my tests. Method: Initially I c

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: On April 12, 2023 8:51:09 AM PDT, Charlie Li wrote: Cy Schubert wrote: I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, and other writes I can easily recreate on my laptop. Here are the results of my tests. Method: Initially I copied my /usr/obj fr

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 12, 2023 8:51:09 AM PDT, Charlie Li wrote: >Cy Schubert wrote: >> I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, and >> other writes I can easily recreate on my laptop. Here are the results of my >> tests. >> >> Method: >> >> Initially I copied my /usr/obj fr

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/12/23, FreeBSD User wrote: > Am Wed, 12 Apr 2023 11:51:09 -0400 > Charlie Li schrieb: > >> Cy Schubert wrote: >> > I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, >> > and other writes >> > I can easily recreate on my laptop. Here are the results of my tests. >> > >>

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Am Wed, 12 Apr 2023 11:51:09 -0400 Charlie Li schrieb: > Cy Schubert wrote: > > I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, > > and other writes > > I can easily recreate on my laptop. Here are the results of my tests. > > > > Method: > > > > Initially I copied my

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs, and other writes I can easily recreate on my laptop. Here are the results of my tests. Method: Initially I copied my /usr/obj from my two build machines (one amd64.amd64 and an i386.i386) to my "sandbo

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 10, 2023 7:51:13 PM PDT, Charlie Li wrote: >I ended up creating a new pool with -o compatibility=openzfs-2.1-freebsd, so >no block_cloning or other features since then. The panic is gone, but still >getting the occasional file corruption on write as evidenced by failed >poudriere build

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

I ended up creating a new pool with -o compatibility=openzfs-2.1-freebsd, so no block_cloning or other features since then. The panic is gone, but still getting the occasional file corruption on write as evidenced by failed poudriere builds. -- Charlie Li …nope, still don't have an exit line.

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Mon, 10 Apr 2023 01:58:00 -0400 Charlie Li wrote: > Cy Schubert wrote: > > Hmm, interesting. I'm experiencing no such panics nor corruption since > > the commit. > > > > Reading a previous email of yours from today block_cloning is not > > enabled. Is it possible that before the regression wa

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: Hmm, interesting. I'm experiencing no such panics nor corruption since the commit. Reading a previous email of yours from today block_cloning is not enabled. Is it possible that before the regression was fixed, while it was wreaking havoc in your zpool, that your zpool became

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Sun, 9 Apr 2023 23:25:44 -0400 Charlie Li wrote: > Charlie Li wrote: > > Cy Schubert wrote: > >>> The file corruption was prior to enabling block_cloning but after > >>> this import. > >>> > >> > >> This regression was fixed  by mjg's commit. I'm not sure which (I'm > >> presently AFK).

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Charlie Li wrote: Cy Schubert wrote: The file corruption was prior to enabling block_cloning but after this import. This regression was fixed  by mjg's commit. I'm not sure which (I'm presently AFK). Both the block_cloning panic and file corruption are still happening as of 351e4592f64b,

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: The file corruption was prior to enabling block_cloning but after this import. This regression was fixed by mjg's commit. I'm not sure which (I'm presently AFK). Both the block_cloning panic and file corruption are still happening as of 351e4592f64b, which is after any s

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On April 9, 2023 6:35:21 PM PDT, Charlie Li wrote: >Cy Schubert wrote: >> On Sun, 9 Apr 2023 12:49:23 -0400 >> Charlie Li wrote: >> >>> Cy Schubert wrote: I've noticed random artifacts in my emails since the new ZFS. I'm not sure if it's related to block_cloning or something else. This

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: On Sun, 9 Apr 2023 12:49:23 -0400 Charlie Li wrote: Cy Schubert wrote: I've noticed random artifacts in my emails since the new ZFS. I'm not sure if it's related to block_cloning or something else. This could mean deeper trouble. I've also started noticing random artefa

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Sun, 9 Apr 2023 12:49:23 -0400 Charlie Li wrote: > Cy Schubert wrote: > > I've noticed random artifacts in my emails since the new ZFS. I'm not sure > > if it's related to block_cloning or something else. This could mean deeper > > trouble. > > > I've also started noticing random artefacts

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

In message , Mateusz Guzik writes: > On 4/9/23, Mateusz Guzik wrote: > > On 4/9/23, FreeBSD User wrote: > >> Am Sun, 9 Apr 2023 13:23:05 -0400 > >> Charlie Li schrieb: > >> > >>> Mateusz Guzik wrote: > >>> > On 4/9/23, Charlie Li wrote: > >>> >> I've also started noticing random artefacts and m

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Mateusz Guzik wrote: ... and got an illegitimate failure: strip: file format not recognized the port builds after retrying iow there is more breakage. i don't know if the merge can be easily reverted now, will have to see about that Yup, this is the random file corruption mode that I mentione

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/9/23, Mateusz Guzik wrote: > On 4/9/23, FreeBSD User wrote: >> Am Sun, 9 Apr 2023 13:23:05 -0400 >> Charlie Li schrieb: >> >>> Mateusz Guzik wrote: >>> > On 4/9/23, Charlie Li wrote: >>> >> I've also started noticing random artefacts and malformed files >>> >> whilst >>> >> building package

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/9/23, FreeBSD User wrote: > Am Sun, 9 Apr 2023 13:23:05 -0400 > Charlie Li schrieb: > >> Mateusz Guzik wrote: >> > On 4/9/23, Charlie Li wrote: >> >> I've also started noticing random artefacts and malformed files whilst >> >> building packages with poudriere, causing all sorts of "exec form

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Am Sun, 9 Apr 2023 13:23:05 -0400 Charlie Li schrieb: > Mateusz Guzik wrote: > > On 4/9/23, Charlie Li wrote: > >> I've also started noticing random artefacts and malformed files whilst > >> building packages with poudriere, causing all sorts of "exec format > >> error"s, missing .so files due

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Mateusz Guzik wrote: On 4/9/23, Charlie Li wrote: I've also started noticing random artefacts and malformed files whilst building packages with poudriere, causing all sorts of "exec format error"s, missing .so files due to corruption, data file corruption causing unintended failure modes, etc. A

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/9/23, Charlie Li wrote: > Cy Schubert wrote: >> I've noticed random artifacts in my emails since the new ZFS. I'm not >> sure >> if it's related to block_cloning or something else. This could mean >> deeper >> trouble. >> > I've also started noticing random artefacts and malformed files whils

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

Cy Schubert wrote: I've noticed random artifacts in my emails since the new ZFS. I'm not sure if it's related to block_cloning or something else. This could mean deeper trouble. I've also started noticing random artefacts and malformed files whilst building packages with poudriere, causing all

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On Sat, Apr 8, 2023 at 5:24 AM Mateusz Guzik wrote: > > On 4/8/23, Kyle Evans wrote: > > On Fri, Apr 7, 2023 at 4:54 PM Mateusz Guzik wrote: > >> > >> On 4/7/23, Mark Millard wrote: > >> > On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: > >> > > >> >> On 4/7/23, Mateusz Guzik wrote: > >> >>> c

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On 4/8/23, Kyle Evans wrote: > On Fri, Apr 7, 2023 at 4:54 PM Mateusz Guzik wrote: >> >> On 4/7/23, Mark Millard wrote: >> > On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: >> > >> >> On 4/7/23, Mateusz Guzik wrote: >> >>> can you try with this: >> >>> >> >>> diff --git >> >>> a/sys/contrib/ope

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On Apr 7, 2023, at 16:29, Kyle Evans wrote: > On Fri, Apr 7, 2023 at 4:54 PM Mateusz Guzik wrote: >> >> On 4/7/23, Mark Millard wrote: >>> On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: >>> On 4/7/23, Mateusz Guzik wrote: > can you try with this: > > diff --git > a/sys

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On Fri, Apr 7, 2023 at 4:54 PM Mateusz Guzik wrote: > > On 4/7/23, Mark Millard wrote: > > On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: > > > >> On 4/7/23, Mateusz Guzik wrote: > >>> can you try with this: > >>> > >>> diff --git > >>> a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_a

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On 4/7/23, Mark Millard wrote: > On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: > >> On 4/7/23, Mateusz Guzik wrote: >>> can you try with this: >>> >>> diff --git >>> a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >>> b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_a

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: > On 4/7/23, Mateusz Guzik wrote: >> can you try with this: >> >> diff --git >> a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> index 16276b08c759..e1bca9ef

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

On 4/7/23, Mateusz Guzik wrote: > can you try with this: > > diff --git > a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h > b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h > index 16276b08c759..e1bca9ef140a 100644 > --- a/sys/contrib/openzfs/include/os/linux/k

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

can you try with this: diff --git a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h index 16276b08c759..e1bca9ef140a 100644 --- a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h +++ b/sys/contrib/o

RE: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import]

Turns out that as of this commit aarch64 (Cortex-A72 and Cortex-A57 examples reported) gets the following even when no zfs media is present (UFS boot): # zpool import x0: f0fa9168 (ucom_cons_softc + efbf1bb8) x1: ff90 ($d.1 + afa318) x2: ff900400 ($d.1 + afa718) x3:

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On Tue, Apr 4, 2023 at 3:55 AM Martin Matuska wrote: > > I have opened a PR for this (includes patch): > https://github.com/openzfs/zfs/pull/14713 > > We still need to address the a_fsizetd problem. > > Maybe I'd say this is a definite maybe. I've attached what I think is the correct fix. a_outcre

Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

I have opened a PR for this (includes patch): https://github.com/openzfs/zfs/pull/14713 We still need to address the a_fsizetd problem. Maybe On 4. 4. 2023 7:22, Rick Macklem wrote: On Mon, Apr 3, 2023 at 10:07 PM Cy Schubert wrote: In message , Rick Macklem writes: On Mon, Apr 3, 2023 at

  1   2   >