Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Shawn Webb
Ah. I think I misinterpreted your email. Sorry about that! On Thu, Apr 15, 2021 at 03:22:41PM -0500, Kyle Evans wrote: > Yes, sorry, this is precisely what I meant. > > On Thu, Apr 15, 2021 at 3:20 PM Shawn Webb wrote: > > > > Could ether_gen_addr be updated to take into account the zero'd > > h

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Kyle Evans
Yes, sorry, this is precisely what I meant. On Thu, Apr 15, 2021 at 3:20 PM Shawn Webb wrote: > > Could ether_gen_addr be updated to take into account the zero'd > hostuuid and handle appropriately like you mentioned below? > > On Thu, Apr 15, 2021 at 03:12:14PM -0500, Kyle Evans wrote: > > I thi

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Shawn Webb
Could ether_gen_addr be updated to take into account the zero'd hostuuid and handle appropriately like you mentioned below? On Thu, Apr 15, 2021 at 03:12:14PM -0500, Kyle Evans wrote: > I think it'd be the right choice, but it needs a little work first. > e.g., it's not a good fit right now for V

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Kyle Evans
I think it'd be the right choice, but it needs a little work first. e.g., it's not a good fit right now for VMs that don't use loader, for instance, because it relies on the hostuuid actually being somewhat unique or else it generates the same MAC address across different VMs and you end up with co

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Kevin Bowling
I would like to discuss this further, it crossed my mind, but none of the intel drivers currently use it. If this is the right KPI I think a review should be prepared that updates e1000, ixgbe (ixv), ixl (iavf) in one go. Regards, Kevin On Thu, Apr 15, 2021 at 12:36 PM Kyle Evans wrote: > > On

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Kyle Evans
On Thu, Apr 15, 2021 at 2:32 PM Ronald Klop wrote: > > On 4/15/21 8:48 PM, Kevin Bowling wrote: > > The branch main has been updated by kbowling (ports committer): > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=68a46f11eadab48a1da9e3d3900569a6a1ce142e > > > > commit 68a46f11eadab48a1da9

Re: git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Ronald Klop
On 4/15/21 8:48 PM, Kevin Bowling wrote: The branch main has been updated by kbowling (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=68a46f11eadab48a1da9e3d3900569a6a1ce142e commit 68a46f11eadab48a1da9e3d3900569a6a1ce142e Author: Kevin Bowling AuthorDate: 2021-04-15 18:45

git: 68a46f11eada - main - e1000: Restore VF interface random MAC

2021-04-15 Thread Kevin Bowling
The branch main has been updated by kbowling (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=68a46f11eadab48a1da9e3d3900569a6a1ce142e commit 68a46f11eadab48a1da9e3d3900569a6a1ce142e Author: Kevin Bowling AuthorDate: 2021-04-15 18:45:02 + Commit: Kevin Bowling Commit