Re: git: aefe30c54371 - main - cat: capsicumize it

2021-01-16 Thread Shawn Webb
Also to note: Something about this change causes a kernel panic under heavy load (poudriere running 20 jobs with poudriere configured to use tmpfs for the entire job). Screenshot of kernel panic: https://photos.app.goo.gl/dXBpW7sbn1iWQaJj9 On Sun, Jan 17, 2021 at 01:03:25AM +0100, Mariusz Zaborsk

Re: git: aefe30c54371 - main - cat: capsicumize it

2021-01-16 Thread Mariusz Zaborski
Thank you for raising your concerns. We discussed that, and for now, we will disable sandboxing in the cat. We will try to measure where the bottlenecks are and try to address them. We should try to sandbox even as simple tools like cat or tail, but not for any cost. If we have a high cost, we may

Re: git: aefe30c54371 - main - cat: capsicumize it

2021-01-16 Thread Cy Schubert
In message <202101161448.10gemui4095...@mail.karels.net>, Mike Karels writes: > Mateusz wrote: > > I have to strongly disagree with this change. > > > truss -f cat /etc/motd immediately reveals most peculiar overhead > > which comes with it. > > > Some examples: > > - pdfork is called 3 times and

Re: git: aefe30c54371 - main - cat: capsicumize it

2021-01-16 Thread Mike Karels
Mateusz wrote: > I have to strongly disagree with this change. > truss -f cat /etc/motd immediately reveals most peculiar overhead > which comes with it. > Some examples: > - pdfork is called 3 times and fork 1 time, spawning 4 processes in total > - the file is opened twice: > 5548: openat(AT_F

Re: git: aefe30c54371 - main - cat: capsicumize it

2021-01-16 Thread Mateusz Guzik
I have to strongly disagree with this change. truss -f cat /etc/motd immediately reveals most peculiar overhead which comes with it. Some examples: - pdfork is called 3 times and fork 1 time, spawning 4 processes in total - the file is opened twice: 5548: openat(AT_FDCWD,"/etc/motd",O_RDONLY,00)

git: aefe30c54371 - main - cat: capsicumize it

2021-01-15 Thread Mariusz Zaborski
The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=aefe30c5437159a5399bdbc1974d6fbf40f2ba0f commit aefe30c5437159a5399bdbc1974d6fbf40f2ba0f Author: Mariusz Zaborski AuthorDate: 2021-01-15 20:22:29 + Commit: Mariusz Zaborski CommitDate: 2021-01