Re: PSA: NS_IMPL_ISUPPORTS and friends are now variadic

2014-04-28 Thread Henri Sivonen
On Mon, Apr 28, 2014 at 7:18 AM, Birunthan Mohanathas birunt...@mohanathas.com wrote: Bugs 900903 and 900908 introduced variadic variants of NS_IMPL_ISUPPORTS, NS_IMPL_QUERY_INTERFACE, NS_IMPL_CYCLE_COLLECTION, etc. and removed the old numbered macros. Cool. Is there a script that rewrites mq

Re: Too many system compartments at start-up

2014-04-28 Thread Florian Quèze
Le jeudi 24 avril 2014 10:51:12 UTC+2, Nicholas Nethercote a écrit : I've given the list of current start-up (+30s) modules below. This list contains several compartments for XPCOM components handling the command line (eg. nsSetDefaultBrowser.js or nsDefaultCLH.js). I wouldn't expect them

Re: PSA: NS_IMPL_ISUPPORTS and friends are now variadic

2014-04-28 Thread Neil
Birunthan Mohanathas wrote: Note that due to technical details, the new macros will reject uses with zero variadic arguments. In such cases, you will want to continue to use the zero-numbered macro, e.g. NS_IMPL_ISUPPORTS0(nsFoo). I can't help wondering who would need to implement only

Re: PSA: NS_IMPL_ISUPPORTS and friends are now variadic

2014-04-28 Thread Benoit Jacob
2014-04-28 0:18 GMT-04:00 Birunthan Mohanathas birunt...@mohanathas.com: Bugs 900903 and 900908 introduced variadic variants of NS_IMPL_ISUPPORTS, NS_IMPL_QUERY_INTERFACE, NS_IMPL_CYCLE_COLLECTION, etc. and removed the old numbered macros. So, instead of e.g. NS_IMPL_ISUPPORTS2(nsFoo, nsIBar,

Re: Policing dead/zombie code in m-c

2014-04-28 Thread Ehsan Akhgari
On 2014-04-28, 8:59 AM, Henri Sivonen wrote: New question: We have various scriptable nsIFoo stuff (e.g. nsIParserService, nsIScriptableUConv) on the fringes of Gecko for use by mailnews, the Firefox UI or extensions. Since Gaia doesn't use XPCOM, those things are dead code in B2G, right? Would

Re: PSA: NS_IMPL_ISUPPORTS and friends are now variadic

2014-04-28 Thread Benoit Jacob
2014-04-28 14:18 GMT-04:00 Trevor Saunders trev.saund...@gmail.com: On Mon, Apr 28, 2014 at 02:07:07PM -0400, Benoit Jacob wrote: 2014-04-28 12:17 GMT-04:00 Birunthan Mohanathas birunt...@mohanathas.com: On 28 April 2014 14:18, Benoit Jacob jacob.benoi...@gmail.com wrote: Question:

Re: OS.File design issue from bug 961080 (making downloads respect umask)

2014-04-28 Thread David Rajchenbach-Teller
On 28/04/14 21:00, Paolo Amadini wrote: On 4/28/2014 7:44 PM, Zack Weinberg wrote: Based on all discussion to this point, I'm proposing this low-level API: fileObject.setPermissions(options); OS.File.setPermissions(path, options); Generally, this looks good to me. I'd rather use unix

Re: PSA: NS_IMPL_ISUPPORTS and friends are now variadic

2014-04-28 Thread Blake Kaplan
Neil n...@parkwaycc.co.uk wrote: I can't help wondering who would need to implement only nsISupports. It can't be for the refcounting, because you can just use inline refcounting. And you've got no way of telling whether an arbitrary nsISupports is your object or not. Well, except that in