Re: Getting rid of already_AddRefed?

2014-12-24 Thread Ehsan Akhgari
On 2014-12-24 3:21 PM, Neil wrote: Ehsan Akhgari wrote: On 2014-12-23 5:30 PM, Eric Rescorla wrote: nothing stops the callee from simple assigning the raw pointer to some location that outlives the function call. That's actually pretty easy to detect and disallow! Filed bug 1115175. Alth

Re: Getting rid of already_AddRefed?

2014-12-24 Thread Neil
Ehsan Akhgari wrote: On 2014-12-23 5:30 PM, Eric Rescorla wrote: nothing stops the callee from simple assigning the raw pointer to some location that outlives the function call. That's actually pretty easy to detect and disallow! Filed bug 1115175. Although we want to allow it in the case

Re: Is anyone still using JS strict warnings?

2014-12-24 Thread Nick Fitzgerald
Yes there are cases that are specialized, but there are cases that aren't found. I'm having trouble reproducing because, as I mentioned before, the way the code is loaded/eval'd determines if the messages are logged or not and it doesn't seem they are in the console or scratchpad. This is hugely an

Re: Getting rid of already_AddRefed?

2014-12-24 Thread Joshua Cranmer 🐧
On 12/23/2014 3:03 PM, Jeff Walden wrote: On 12/23/2014 10:48 AM, L. David Baron wrote: Our convention has always been to pass raw pointers, generally with the assumption that the caller is expected to ensure the pointer lives across the function call. Like Eric, I would like us to move away fr

Re: elm changesets gone walkies?

2014-12-24 Thread James Graham
On 24/12/14 11:19, Philip Chee wrote: > https://bugzilla.mozilla.org/show_bug.cgi?id=771238#c1 > >> http://hg.mozilla.org/projects/elm/rev/ab6d458a4258 > Not unexpectedly this doesn't exist any more. So I check mozilla-central > assuming that elm had been merged to m-c: >> https://hg.mozilla.org/m

elm changesets gone walkies?

2014-12-24 Thread Philip Chee
https://bugzilla.mozilla.org/show_bug.cgi?id=771238#c1 > http://hg.mozilla.org/projects/elm/rev/ab6d458a4258 Not unexpectedly this doesn't exist any more. So I check mozilla-central assuming that elm had been merged to m-c: > https://hg.mozilla.org/mozilla-central/log?rev=ab6d458a4258 This also co