Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Vladan Djeric
There are known issues with the test infrastructure (e.g. differences in weekend vs weekday results) and those known issues are currently being masked with human judgement. A-Team has investigated these issues, and fixed some of them, but fixing the rest will take a non-trivial amount of effort as

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Martin Thomson
On Fri, Aug 14, 2015 at 3:44 PM, Vladan Djeric wrote: > Is this the ts_paint regression you're referring to? > https://groups.google.com/forum/#!searchin/mozilla.dev.tree-alerts/ts_paint/mozilla.dev.tree-alerts/FArVsa8guXg/FfY91JK7AAAJ Yeah. I only ask because in exercising judgment suppresses i

Re: Allowing web apps to delay layout/rendering on startup

2015-08-14 Thread James Burke
On Tue, Aug 11, 2015 at 5:17 PM, James Burke wrote: > https://github.com/jrburke/fxos-startup-test > > There are three variations mentioned in the README, each with a > profile.sh capture "Profile" link: I did a pass at the "Regular" profile and put the notes here: https://github.com/jrburke/fxos

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Vladan Djeric
I don't think anyone systematically logs the false-positives. Is this the ts_paint regression you're referring to? https://groups.google.com/forum/#!searchin/mozilla.dev.tree-alerts/ts_paint/mozilla.dev.tree-alerts/FArVsa8guXg/FfY91JK7AAAJ I don't think the perf sheriffs filed a bug for that one,

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Martin Thomson
On Fri, Aug 14, 2015 at 2:56 PM, Vladan D wrote: > Tests are reliable if they detect regressions, aren't very noisy, and if they > measure things that have a real impact on actual Firefox user experience. Do we track false positives on these? I say that because I got a mail just last week for t

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Vladan D
Tests are reliable if they detect regressions, aren't very noisy, and if they measure things that have a real impact on actual Firefox user experience. We're using past experience with the tests to determine which ones meet this criteria. On Friday, August 14, 2015 at 5:45:35 PM UTC-4, Kartikay

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Kartikaya Gupta
In general I'm in favour of this proposal, although it will probably come back to haunt me in the not-too-distant future. That being said I would like to know what criteria you used to distinguish "reliable" talos tests from the rest. kats On Fri, Aug 14, 2015 at 5:26 PM, Vladan Djeric wrote: >

New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Vladan Djeric
The perf team and the A-Team would like to test out a new policy: we want to back out patches that cause significant Talos regressions on Windows builds. We would like to get developers’ feedback before starting this experiment. Why are we doing this? Essentially, we would like more Talos regress

Re: Stop using PL_strchr/strstr et al for parsing - use mozilla::Tokenizer

2015-08-14 Thread Honza Bambas
On 7/29/2015 22:51, Daniel Stenberg wrote: On Wed, 29 Jul 2015, Honza Bambas wrote: I've recently introduced a class making parsing string inputs much safer and simpler. http://www.janbambas.cz/string-parsing-made-simple-with-mozillatokenizer/ Nice! How does it act when hitting 64bit inte