Re: Should cheddar-generated headers be checked in?

2017-02-26 Thread Xidorn Quan
On Mon, Feb 27, 2017, at 02:33 AM, Henri Sivonen wrote: > On Thu, Feb 23, 2017 at 4:37 PM, Ted Mielczarek > wrote: > > On Thu, Feb 23, 2017, at 06:40 AM, Emilio Cobos Álvarez wrote: > >> On Thu, Feb 23, 2017 at 08:25:30AM +0200, Henri Sivonen wrote: > >> > On Wed, Feb 22,

Re: Editing vendored crates

2017-02-26 Thread Xidorn Quan
On Mon, Feb 27, 2017, at 09:10 AM, Bobby Holley wrote: > On Sun, Feb 26, 2017 at 9:51 AM, Henri Sivonen > wrote: > > > I tried to add some panics to a vendored to create (rust-encoding) to > > see if the code in question runs. However, I didn't get to the running > > part,

Re: Intent to implement: Frames timing functions

2017-02-26 Thread Brian Birtles
On Sat, Feb 25, 2017 at 1:09 AM, wrote: > On Thursday, February 23, 2017 at 9:09:58 AM UTC-6, Boris Chiou wrote: >> *Preference behind which this will be implemented*: I'm not sure. I think >> we don't need it because it is just a variant of the step timing function, >> and

Re: Editing vendored crates

2017-02-26 Thread Bobby Holley
On Sun, Feb 26, 2017 at 9:51 AM, Henri Sivonen wrote: > I tried to add some panics to a vendored to create (rust-encoding) to > see if the code in question runs. However, I didn't get to the running > part, because the edited code failed to build. > > It turns out that each

Re: Editing vendored crates

2017-02-26 Thread Bobby Holley
On Sun, Feb 26, 2017 at 2:02 PM, Manish Goregaokar wrote: > > [replace] section to Cargo.toml of libgkrust pointing to the edited > > crate under third-party/rust or adding paths = [ "third-party/rust" ] > > to .cargo/config.in don't make Cargo happy. > > [replace] is the

Re: Editing vendored crates

2017-02-26 Thread Manish Goregaokar
> [replace] section to Cargo.toml of libgkrust pointing to the edited > crate under third-party/rust or adding paths = [ "third-party/rust" ] > to .cargo/config.in don't make Cargo happy. [replace] is the way to do it, but it has to point to a crate outside of the vendoring directory. The

Editing vendored crates

2017-02-26 Thread Henri Sivonen
I tried to add some panics to a vendored to create (rust-encoding) to see if the code in question runs. However, I didn't get to the running part, because the edited code failed to build. It turns out that each vendored crate has a .cargo-checksum.json file that contains hashes of all the files

Re: Should cheddar-generated headers be checked in?

2017-02-26 Thread Henri Sivonen
On Thu, Feb 23, 2017 at 4:37 PM, Ted Mielczarek wrote: > On Thu, Feb 23, 2017, at 06:40 AM, Emilio Cobos Álvarez wrote: >> On Thu, Feb 23, 2017 at 08:25:30AM +0200, Henri Sivonen wrote: >> > On Wed, Feb 22, 2017 at 5:49 PM, Ted Mielczarek >> > wrote: >>