[cross-posting to firefox-dev]
Fellow mozillians,
bug 1402519 [1] just landed and it introduces a dummy implementation of
the crash reporter which is built when configuring with
--disable-crash-reporter. This removes the need for bracketing calls to
the crash reporter with #ifdef MOZ_CRASHREPORTE
I just came to realize:
ReentrantMonitorAutoEnter lock1(...);
ReentrantMonitorAutoEnter lock2(...);
{
ReentrantMonitorAutoExit unlock1(...);
// This will not release the monitor.
{
ReentrantMonitorAutoExit unlock2(...);
// This will release the monitor.
}
}
Sometimes it is not cle
Hi,
I didn't see package-manifest changes in the bug.
I assume this needs to stay in as-is?
Thanks
FRG
+++ snip +++
; [Crash Reporter]
;
#ifdef MOZ_CRASHREPORTER
@RESPATH@/components/CrashService.manifest
@RESPATH@/components/CrashService.js
@RESPATH@/components/toolkit_crashservice.xpt
#ifde
On Thu, Nov 23, 2017 at 4:00 PM, smaug wrote:
> On 11/23/2017 11:54 PM, Botond Ballo wrote:
>
>> I think it makes sense to hide a 'new' call in a Make* function when
>> you're writing an abstraction that handles allocation *and*
>> deallocation.
>>
>> So MakeUnique makes sense, because UniquePtr
On 24/11/2017 05:18, Frank-Rainer Grahl wrote:
> Hi,
>
> I didn't see package-manifest changes in the bug.
>
> I assume this needs to stay in as-is?
Yes, when we build with --disable-crashreporter we still don't want the
various other bits (including the crash reporter UI) to be built and
packag
On Fri, Nov 24, 2017 at 2:55 AM, Gabriele Svelto
wrote:
> [cross-posting to firefox-dev]
>
> Fellow mozillians,
> bug 1402519 [1] just landed and it introduces a dummy implementation of
> the crash reporter which is built when configuring with
> --disable-crash-reporter. This removes the need fo
Yeah I've always been pretty appalled that this exists. We should remove it
if at all possible.
bholley
On Nov 24, 2017 04:45, wrote:
I just came to realize:
ReentrantMonitorAutoEnter lock1(...);
ReentrantMonitorAutoEnter lock2(...);
{
ReentrantMonitorAutoExit unlock1(...);
// This will n
7 matches
Mail list logo