Re: Launch of Phabricator and Lando for mozilla-central

2018-06-07 Thread James Graham
On 06/06/2018 15:57, Mark Côté wrote: Similarly, there are two other features which are not part of initial launch but will follow in subsequent releases: * Stacked revisions. If you have a stack of revisions, that is, two or more revisions with parent-child relationships, Lando cannot land th

Re: Launch of Phabricator and Lando for mozilla-central

2018-06-07 Thread Mark Côté
On Wednesday, 6 June 2018 19:58:43 UTC-4, Xidorn Quan wrote: > On Thu, Jun 7, 2018, at 12:57 AM, Mark Côté wrote: > > Phabricator is a suite of applications, but we are primarily using the > > code-review tool, called Differential, which will be taking the place of > > MozReview and Splinter. Bu

Pseudolocalization in Firefox Nightly!

2018-06-07 Thread Zibi Braniecki (Gandalf)
Hi all! We've just landed a new hot developer-oriented feature in Firefox Nightly - Pseudolocalization. Pseudolocalization allows developers to quickly test their UI against fake localizations helping us discover internationalization issues earlier in the cycle. You can find an introduction vide

Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo

2018-06-07 Thread Jeff Gilbert
We have a name conflict under the current system when trying to use these two classes from the webgpu sketch webidl: - WebGPUBuffer - WebGPUBufferBinding I'm proposing renaming the generated bindings classes from dom::FooBinding to dom::binding::Foo. This seems like a reasonable use of namespaces,

Re: Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo

2018-06-07 Thread Kyle Machulis
+1 on the namespace idea. We started using mozilla::dom::FooBinding::[ConstantName] namespace for constants in bug 792059, so we may also want to change that to dom::binding::Foo::[ConstantName] for consistency sake. On Thu, Jun 7, 2018 at 1:03 PM, Jeff Gilbert wrote: > We have a name conflict u

Re: Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo

2018-06-07 Thread Boris Zbarsky
On 6/7/18 4:24 PM, Kyle Machulis wrote: +1 on the namespace idea. We started using mozilla::dom::FooBinding::[ConstantName] namespace for constants in bug 792059, so we may also want to change that to dom::binding::Foo::[ConstantName] for consistency sake. Right, that change would be part of th

PSA: Please use XPCOMUtils.defineLazyGlobalGetters rather than Cu.importGlobalProperties

2018-06-07 Thread Kris Maglione
tl;dr: importGlobalProperties is expensive. If you don't need the imported properties immediately, please use defineLazyGlobalGetters instead. Calling importGlobalProperties immediately defines the properties that you're importing and any prototypes that they require. Aside from CPU overhead, t