Re: Intent to ship: CSP Violation DOM Events

2018-07-19 Thread amarchesini
I'm going to enable CSP Violation Events by default in Firefox 63. Bug 1432523. I and ckerschb have done a good job to make our code compliant with the latest CSP3 spec and we pass (almost) all the related WPT tests. The only remaining bit is related to (bug 1473630) but we decided to work on

Re: C++ standards proposal for a embedding library

2018-07-19 Thread Ted Mielczarek
On Wed, Jul 18, 2018, at 12:45 PM, Botond Ballo wrote: > Hi everyone, > > With the proposal for a standard 2D graphics library now on ice [1], > members of the C++ standards committee have been investigating > alternative ways of giving C++ programmers a standard way to write > graphical and inter

Re: C++ standards proposal for a embedding library

2018-07-19 Thread Peter Saint-Andre
Hear, hear and well said! On 7/19/18 11:53 AM, Ted Mielczarek wrote: > On Wed, Jul 18, 2018, at 12:45 PM, Botond Ballo wrote: >> Hi everyone, >> >> With the proposal for a standard 2D graphics library now on ice [1], >> members of the C++ standards committee have been investigating >> alternative

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Myk Melez
Nicholas Nethercote wrote on 2018-07-17 21:23: This is a good example of how prefs is a far more general mechanism than I would like, leading to all manner of use and abuse. "All I want is a key-value store, with fast multi-threaded access, where the keys aren't known ahead of time." Agreed, the

System add-ons no longer visible by default in about:debugging

2018-07-19 Thread Mark Striemer
Bug 1425347 [1] will update about:debugging so that system add-ons are no longer shown in official builds of Firefox. If you build Firefox locally you will still see system add-ons in their own section. If you would like to show system add-ons in an official build you can flip the `devtools.aboutd

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Kris Maglione
On Tue, Jul 17, 2018 at 03:49:41PM -0700, Jeff Gilbert wrote: We should totally be able to afford the very low cost of a rarely-contended lock. What's going on that causes uncached pref reads to show up so hot in profiles? Do we have a list of problematic pref keys? So, at the moment, we read a

Re: C++ standards proposal for a embedding library

2018-07-19 Thread Mike Hommey
On Wed, Jul 18, 2018 at 12:45:30PM -0400, Botond Ballo wrote: > Hi everyone, > > With the proposal for a standard 2D graphics library now on ice [1], > members of the C++ standards committee have been investigating > alternative ways of giving C++ programmers a standard way to write > graphical an

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Justin Dolske
I know we've had code that, instead of reading a pref directly, checks the pref once in an init() and uses pref observers to watch for any changes to it. (i.e., basically mirrors the pref into some module-local variable, at which point you can roll your own locking or whatever to make it threadsafe

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Daniel Veditz
On Tue, Jul 17, 2018 at 9:23 PM, Nicholas Nethercote wrote: > This is a good example of how prefs is a far more general mechanism than I > would like, leading to all manner of use and abuse. "All I want is a > key-value store, with fast multi-threaded access, where the keys aren't > known ahead o

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Kris Maglione
On Thu, Jul 19, 2018 at 02:37:07PM -0700, Justin Dolske wrote: I know we've had code that, instead of reading a pref directly, checks the pref once in an init() and uses pref observers to watch for any changes to it. (i.e., basically mirrors the pref into some module-local variable, at which poin

PSA: Default thread stack size decreased to 256K

2018-07-19 Thread Kris Maglione
tl;dr: Bug 1476828 significantly decreased the default thread stack size. If you notice any thread abort issues, please file bugs blocking that bug. For some time, our default stack size for thread pools has been 256K on most platforms, but the stack size for other threads has remained set to t

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Jeff Gilbert
Using a classic read/write exclusive lock, we would only every contend on read+write or write+write, which are /rare/. It's really, really nice when we can have dead-simple threadsafe APIs, instead of requiring people to jump through hoops or roll their own dispatch code. (fragile) IIRC most new A

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Kris Maglione
On Thu, Jul 19, 2018 at 07:17:13PM -0700, Jeff Gilbert wrote: Using a classic read/write exclusive lock, we would only every contend on read+write or write+write, which are /rare/. That might be true if we gave up on the idea of switching to Robin Hood hashing. But if we don't, then every look

Re: PSA: Major preference service architecture changes inbound

2018-07-19 Thread Nicholas Nethercote
On Fri, Jul 20, 2018 at 7:37 AM, Daniel Veditz wrote: > ​Prefs might be a terrible way to implement that functionality, but it's > been used that way as long as we've had prefs in Mozilla so there seems to > be a need for it. Early offenders: printer setup, mail accounts, external > protocol hand