Re: [ Intent to Change ] Enabling the MOVED resolution in Bugzilla

2019-09-06 Thread Emma Humphries
Update to this. After discussion with some folks on the Core side such as AvK, we're going to make the assumption that bugs in Core, Firefox, and Toolkit *should not* be resolved as MOVED and we'll use queries to monitor that. I'll be enabling the change early next week . -- Emma On Tue, Aug 27,

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Jeff Gilbert
Notably, aFoo is neither Google nor Rust style. If we didn't already have aFoo as a style, we certainly wouldn't adopt it today. On Fri, Sep 6, 2019 at 6:59 AM Botond Ballo wrote: > On Fri, Sep 6, 2019 at 9:40 AM Andrew Sutherland > wrote: > > But of course, if this was all being done from insi

Re: Intent to ship: Event-based form participation

2019-09-06 Thread Daniel Veditz
On Fri, Sep 6, 2019 at 3:07 AM John Dai wrote: > Is this feature enabled by default in sandboxed iframes? No. > But it's not specifically disabled in sandboxed frames or behind a non-default preference setting, right? If a sandboxed frame has allow-forms then this event is available along with a

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Botond Ballo
On Fri, Sep 6, 2019 at 9:40 AM Andrew Sutherland wrote: > But of course, if this was all being done from inside an editor or a > debugger, no matter what tricks searchfox can do, they can't help you > elsewhere. Editors can of course do things of their own to help you on this front. For example,

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread David Teller
I'm sure that Searchfox could have useful highlights. However, as you guessed, this was something that happened within an editor + debugger, so there's only so much we can do in this direction. Cheers, David On 06/09/2019 15:40, Andrew Sutherland wrote: > On 9/6/19 7:31 AM, David Teller wrote:

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Andrew Sutherland
On 9/6/19 7:31 AM, David Teller wrote: For what it's worth, I recently spent half a day attempting to solve a bug which would have been trivial if `a` and `m` prefixes had been present in that part of the code. While I find these notations ugly, they're also useful. Is this something searchfo

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread David Teller
For what it's worth, I recently spent half a day attempting to solve a bug which would have been trivial if `a` and `m` prefixes had been present in that part of the code. While I find these notations ugly, they're also useful. Cheers, David On 06/09/2019 12:57, Honza Bambas wrote: > On 2019-09

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Honza Bambas
On 2019-09-05 23:14, Emilio Cobos Álvarez wrote: Yeah, let's not add a new prefix please. I don't like aFoo either, though it's everywhere so consistency is better than nothing :/. That being said, it shouldn't be hard to write some clang plugin or such that automatically renames function ar

Intent to ship: Event-based form participation

2019-09-06 Thread John Dai
Summary: As of Firefox 71 I intend to turn Event-based form participation on by default. It has been developed behind the dom.formdata.event.enabled preference. It allows for introspection and manipulation of what will be submitted with a form element through a new formdata event. Bug: https://bug