Re: C++ PSA: Use [[nodiscard]] instead of MOZ_MUST_USE

Hello Chris, Thank you so much for doing this. From a static-analysis perspective this helps us greatly avoid possible false positives and enforcing the rule when an actual result return from a function call shouldn’t be discarded. Andi > On 22 Dec 2020, at 02:25, Chris Peterson wrote: > >

Re: Visual Studio Code integration with `clangd` for C/C++ development

> On 16 Sep 2020, at 04:14, Botond Ballo wrote: > > On Tue, Sep 15, 2020 at 6:55 PM Jean-Yves Avenard > wrote: > This broke several features for me (and I use VSCode all the time). One in > particular was the inability to switch between code and header (Ctrl-K >

Re: Visual Studio Code integration with `clangd` for C/C++ development

The documentation for the integration of VSCode with the Mozilla ecosystem is now live at https://firefox-source-docs.mozilla.org/contributing/vscode.html > On 10 Sep 2020, at 19:19, Andi-Bogdan Postelnicu wrote: > > TLDR: VSCode users can type `./mach ide vscode` in order to

Re: Visual Studio Code integration with `clangd` for C/C++ development

r workload options that would help on first > setup? > > - mhoye > > -- Original Message -- > From: "Andrew Halberstadt" > To: "Andi-Bogdan Postelnicu" > Cc: "dev-platform" > Sent: 2020-09-10 12:29:48 PM > Subject: Re: Visual Studi

Re: Visual Studio Code integration with `clangd` for C/C++ development

at what is already being used for "inline parsing errors with limited > auto-fix hints"? > > > On Thu, Sep 10, 2020 at 12:20 PM Andi-Bogdan Postelnicu <mailto:a...@mozilla.com>> wrote: > TLDR: VSCode users can type `./mach ide vscode` in order to get code > comp

Re: Visual Studio Code integration with `clangd` for C/C++ development

Please see my comment inlined > On 11 Sep 2020, at 00:25, Botond Ballo wrote: > > Thanks a lot for your work on this, Andi, this is really neat! > > One question: > > On Thu, Sep 10, 2020 at 12:20 PM Andi-Bogdan Postelnicu <mailto:a...@mozilla.com>> wrote

Visual Studio Code integration with `clangd` for C/C++ development

TLDR: VSCode users can type `./mach ide vscode` in order to get code completion, reference navigation, refactoring, reformatting, etc. Hello all, VSCode is a multi-platform open-source programming editor developed by Microsoft and volunteers. It is partly

Reporting of build errors at review phase

TLDR: We’ve enabled build error reporting for C/C++ on Linux on Phabricator. Hello all, Besides the linting and static analysis that is run on patches at submission, we’ve added the reporting of build errors for C/C++ as Unit Test failures. For now, the build is run on a linux64 machine

Phabricator - ReviewBot supports Coverity Analysis as an analyzer for C/C++

TL;DR -- ReviewBot supports Coverity Analysis as an analyzer for C/C++ Two years ago we have gradually introduced static-analysis during review phase, at first in MozReview and moving on in Phabricator. We have started with clang-tidy for C/C++, clang-format for C/C++/Objective{C,C++} coding

Re: nasm will soon become a build dependency

I can confirm that we are having the same problem on Debian stretch and before manually building nasm we had to disable av1 in order to be able to move further with the static analysis builds for coverity. > On 28 Dec 2018, at 22:19, Botond Ballo wrote: > >> On Fri, Dec 21, 2018 at 4:21 PM

Re: The tree has been reformatted now!

Hello all, I’m coming back with a followup email since I don’t think that in the previous email we mentioned what is the minimum version that should be used for rebasing. o changeset: 501271:bf92aff5b93d | tag: tip | fxtree: central | user:Andi-Bogdan Postelnicu

The tree has been reformatted now!

Hello all Starting with revision 6f3709b3878117466168c40affa7bca0b60cf75b mozilla-central has been formatted using ./mach clang-format following the Google coding style. In order to diminish as much as

Re: redundant(?) code churn and code style issues in bug 525063

I come with a followup on this matter, we’ve backed out the issues. Now the tree should be OK. Please see: https://hg.mozilla.org/mozilla-central/rev/8a94faa5cc60495da5d80d4b3c07bf5877d2e6d8 Thanks, ANdi >

Re: redundant(?) code churn and code style issues in bug 525063

Hello all, Right now we are working on backing out the changes the caused this. I will keep you posted when this is done. P.S it should be done very shortly. > On 13 Apr 2018, at 15:48, Nathan Froyd wrote: > > we're signature.asc Description: Message signed with

Re: Default developer mozconfig with clang

I remember that Og has been added to clang in 4.0 offering a potential better experience than O1, see: https://github.com/llvm-mirror/clang/commit/14bfc9e99e6e6903b09480a22c153032be77ae4e You could also try using O1, since the difference between O0 should be: opt adds: -globalopt -demanded-bits

Release Management project of the month: Static Code Analysis - A brief description of what tools we use for Mozilla products

Hello from Release Management! Once a month we highlight one of our projects to help the Mozilla community discover a useful tool or an interesting contribution opportunity. This month's project is Static Code Analysis - A brief description of what tools we use for Mozilla products. The