Re: Intent to Ship: Set document.URL (location) to url of active document when navigation started for javascript:-generated documents

2017-12-13 Thread Samael Wang
On Tuesday, December 12, 2017 at 3:13:07 PM UTC-6, James Graham wrote: > Do we have cross-browser (web-platform) tests covering this change? Yes. There already exists a test which Firefox doesn't pass currently:

Intent to Ship: Set document.URL (location) to url of active document when navigation started for javascript:-generated documents

2017-12-12 Thread Samael Wang
The current behavior that Firefox would set document.URL to the javascript: URL on navigating to the javascript:-generated document doesn't fit HTML5 standard: https://html.spec.whatwg.org/#javascript-protocol We're going to fix that in bug 836567, and ship it to 59. That would also indicate

nsBrowserStatusFilter::OnStateChange will only deliver STATE_IS_NETWORK requests

2017-11-21 Thread Samael Wang
I'm going to land a patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1414745 to make nsBrowserStatusFilter::OnStateChange only deliver STATE_IS_NETWORK requests. I noticed the mFinishedRequests / mTotalRequests counters used in nsBrowserStatusFilter were buggy and ever since we applied

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Samael Wang
In a rare case that we need to send a "CLOSED TREE" try job, will we be able to do that with ./mach try? Last time I didn't use mach try to submit try job was because of that. ___ dev-platform mailing list dev-platform@lists.mozilla.org

Intent to remove: prerendering

2017-07-28 Thread Samael Wang
There's an experimental framework to support behind a preference implemented last year [1]. We ceased to work on it after realizing it's unlikely to benefit users as Chromium team indicated the usage rate is low and Chromium was going to remove it [2]. We'll clean up the code after 57 release

Re: Aarch64 as higher than tier-3?

2017-01-24 Thread Samael Wang
RyanVM於 2017年1月24日星期二 UTC+8上午3時13分23秒寫道: > Is Google shipping a 64-bit Android emulator for aarch64 yet? Last I > knew, they only supported x86 for their 64-bit emulator. Yes. The latest SDK uses a qemu-2 based emulator with both x86-64 & aarch64 support. There was an old qemu-0.9-ish based

Re: NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION

2016-09-21 Thread Samael Wang
The NS_ASSERTION document [1] says "Don't use NS_ASSERTION", which could be a bit confusing that now some of the similar named macros may be deprecated but some are new and encouraged. Could we possibly have a section in the coding guideline explaining all these NS_ASSERTION / MOZ_ASSERT /