Re: Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Simon Sapin
On 15/03/2019 14:31, Xidorn Quan wrote: Servo has a policy banning duplicate dependencies with a whitelist, and such list currently has: This exact allow-list is not part of Servo’s policy, but is constantly evolving. If you can reduce it (typically by updating some intermediate dependencies

Re: Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Dirkjan Ochtman
On Fri, Mar 15, 2019, 15:39 Andreas Tolfsen wrote: > However, I want to talk a little bit about _why_ we see so many > duplicate crates and what causes it. It is my experience that far > too many dependencies are defined on exact version numbers, e.g. > "log = 0.3.9", which effectively forces

Re: Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Andreas Tolfsen
Also sprach Xidorn Quan: > Should we have some kind of policy to address duplicate dependencies > in Gecko as well? Maybe I'm missing something but I don't think I'm > aware of any previous discussion about this. Deduplicating crate dependencies has so far been a mostly heroic undertaking done

Re: Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Nathan Froyd
On Fri, Mar 15, 2019 at 9:32 AM Xidorn Quan wrote: > Should we have some kind of policy to address duplicate dependencies in Gecko > as well? Maybe I'm missing something but I don't think I'm aware of any > previous discussion about this. I remember IRC discussions about this, but there were

Re: Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Kartikaya Gupta
FWIW there often ad-hoc attempts to deduplicate Rust dependencies, and they often run into nontrivial blockers. Currently there's a few things blocked on bug 1530448. On Fri, Mar 15, 2019 at 9:32 AM Xidorn Quan wrote: > > Hi all, > > Recently I tried to build Firefox on cloud, and noticed that

Duplicate dependency policy for Rust in mozilla-central?

2019-03-15 Thread Xidorn Quan
Hi all, Recently I tried to build Firefox on cloud, and noticed that building Rust dependencies is now a significant part of it. Another thing I noticed is that, we have lots of duplicate Rust dependencies. I scanned Cargo.lock in the root and found that we have: * 2 versions of block-buffer