Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Kris Maglione
+1 for adding it back in the future. Even if memory usage isn't as directly related to performance as CPU usage is, it has a *huge* effect on performance on memory constrained systems, if it causes them to have to swap. Also, in my experience, the overlap between poorly-performing code and

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Eric Rahm
Thanks Florian, considering it's roughly unmaintained right now, leaking, and showing up in perf profiles it sounds reasonable to remove the memory section. I've filed bug 1475301 [1] to allow us to measure USS off main thread; we can deal with adding that back in the future if it makes sense. -e

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Florian Quèze
On Thu, Jul 12, 2018 at 1:18 AM, Eric Rahm wrote: > What performance issues are you seeing? RSS and USS should be relatively > lightweight and the polling frequency isn't very high. It seems ResidentUniqueDistinguishedAmount does blocking system calls, resulting in blocking the main thread for

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-11 Thread Eric Rahm
This was added in bug 1255843 [1]. I don't feel to strongly about keeping it around, I believe mconley and mrbkap came up with the idea of adding it. It's *much* more lightweight than about:memory and provides automatic updates which is nice for monitoring without external tools. What performance

Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-11 Thread Florian Quèze
Context: we are currently redesigning about:performance to make it more useful for users. This section of the current about:performance page provides information that isn't actionable for users, and collecting this information causes performance issues, so I think it's time to remove it. I filed