Re: No more #ifdef MOZ_CRASHREPORTER directives needed when using crash reporter functions

2017-11-24 Thread Nicholas Alexander
On Fri, Nov 24, 2017 at 2:55 AM, Gabriele Svelto wrote: > [cross-posting to firefox-dev] > > Fellow mozillians, > bug 1402519 [1] just landed and it introduces a dummy implementation of > the crash reporter which is built when configuring with > --disable-crash-reporter. This removes the need fo

Re: No more #ifdef MOZ_CRASHREPORTER directives needed when using crash reporter functions

2017-11-24 Thread Gabriele Svelto
On 24/11/2017 05:18, Frank-Rainer Grahl wrote: > Hi, > > I didn't see package-manifest changes in the bug. > > I assume this needs to stay in as-is? Yes, when we build with --disable-crashreporter we still don't want the various other bits (including the crash reporter UI) to be built and packag

Re: No more #ifdef MOZ_CRASHREPORTER directives needed when using crash reporter functions

2017-11-24 Thread Frank-Rainer Grahl
Hi, I didn't see package-manifest changes in the bug. I assume this needs to stay in as-is? Thanks FRG +++ snip +++ ; [Crash Reporter] ; #ifdef MOZ_CRASHREPORTER @RESPATH@/components/CrashService.manifest @RESPATH@/components/CrashService.js @RESPATH@/components/toolkit_crashservice.xpt #ifde

No more #ifdef MOZ_CRASHREPORTER directives needed when using crash reporter functions

2017-11-24 Thread Gabriele Svelto
[cross-posting to firefox-dev] Fellow mozillians, bug 1402519 [1] just landed and it introduces a dummy implementation of the crash reporter which is built when configuring with --disable-crash-reporter. This removes the need for bracketing calls to the crash reporter with #ifdef MOZ_CRASHREPORTE