Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

Great! :) On Fri, May 18, 2018 at 2:58 PM Kris Maglione wrote: > Already done. :) https://bugzil.la/1460092 > > On Fri, May 18, 2018 at 02:48:20PM -0400, Jared Wein wrote: > >Have you looked in to adding an eslint rule for this? The eslint rule[1] > >that recommends usage

Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

Already done. :) https://bugzil.la/1460092 On Fri, May 18, 2018 at 02:48:20PM -0400, Jared Wein wrote: Have you looked in to adding an eslint rule for this? The eslint rule[1] that recommends usage of ChromeUtils.defineModuleGetter instead of XPCOMUtils.defineLazyModuleGetter has been very

Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

Have you looked in to adding an eslint rule for this? The eslint rule[1] that recommends usage of ChromeUtils.defineModuleGetter instead of XPCOMUtils.defineLazyModuleGetter has been very useful. [1]

PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

Bug 1456035 added a ChromeUtils.generateQI helper to create QueryInterface methods for JS objects. The QueryInterface methods generated by this function are highly optimized, and have a fast path for calls from XPConnect. Which is to say, please use this method rather than manually writing